RFR: JDK-8273387: remove some unreferenced gtk-related functions

2021-09-07 Thread Matthias Baesken
Please review this small change. Looks like there are a few functions, like gtk2_paint_diamond, that are unreferenced and can be removed. Thanks, Matthias - Commit messages: - JDK-8273387 Changes: https://git.openjdk.java.net/jdk/pull/5384/files Webrev:

Integrated: JDK-8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c

2021-03-02 Thread Matthias Baesken
On Fri, 26 Feb 2021 14:19:03 GMT, Matthias Baesken wrote: > The function wcstombsdmp is called at a few places in awt_InputMethod.c. > This function needs checking of a NULL return value and freeing of the memory > allocated by this function. However this is missing at one place in

RFR: JDK-8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c

2021-02-26 Thread Matthias Baesken
The function wcstombsdmp is called at a few places in awt_InputMethod.c. This function needs checking of a NULL return value and freeing of the memory allocated by this function. However this is missing at one place in the file. - Commit messages: - JDK-8262461 Changes:

Integrated: JDK-8260426: awt debug_mem.c DMem_AllocateBlock might leak memory

2021-01-27 Thread Matthias Baesken
On Wed, 27 Jan 2021 09:56:05 GMT, Matthias Baesken wrote: > It seems that the function DMem_AllocateBlock (debug_mem.c) has an early > return that might lead to memory leaks. > See also the sonar issue Potential leak of memory pointed to by 'header' : > https://sonarcloud.io/proje

RFR: JDK-8260426: awt debug_mem.c DMem_AllocateBlock might leak memory

2021-01-27 Thread Matthias Baesken
It seems that the function DMem_AllocateBlock (debug_mem.c) has an early return that might lead to memory leaks. See also the sonar issue Potential leak of memory pointed to by 'header' : https://sonarcloud.io/project/issues?id=shipilev_jdk=c=AXck8B7zBBG2CXpcngZM=false=BLOCKER=BUG -

Integrated: JDK-8255681: print callstack in error case in runAWTLoopWithApp

2020-11-03 Thread Matthias Baesken
On Tue, 3 Nov 2020 08:45:20 GMT, Matthias Baesken wrote: > Currently in case of occurences of an NSException in runAWTLoopWithApp we > catch the exception just print a simple error message like this : > > 2020-10-30 15:28:33.027 java[634:8435] Apple AWT Startup Exception: Cannot

RFR: JDK-8255681: print callstack in error case in runAWTLoopWithApp

2020-11-03 Thread Matthias Baesken
Currently in case of occurences of an NSException in runAWTLoopWithApp we catch the exception just print a simple error message like this : 2020-10-30 15:28:33.027 java[634:8435] Apple AWT Startup Exception: Cannot lock focus on image , because it is size zero. 2020-10-30 15:28:33.306

Integrated: JDK-8253791: Issue with useAppleColor check in CSystemColors.m

2020-09-29 Thread Matthias Baesken
On Tue, 29 Sep 2020 14:40:27 GMT, Matthias Baesken wrote: > While looking into XCode 12 compilation issues, a problem in > jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m was found > when checking the useAppleColor flag . > Because this is a general issue and not

RFR: JDK-8253791: Issue with useAppleColor check in CSystemColors.m

2020-09-29 Thread Matthias Baesken
While looking into XCode 12 compilation issues, a problem in jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m was found when checking the useAppleColor flag . Because this is a general issue and not really much related to XCode 12 (just shown when using the new compiler) a

Re: RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-29 Thread Matthias Baesken
On Tue, 29 Sep 2020 07:11:34 GMT, Matthias Baesken wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line 129: >> >>> 127: NSColor* result = nil; >>> 128: >>> 129: if (colorIndex < ((useAppleColor) ? >&g

Re: RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-29 Thread Matthias Baesken
On Fri, 25 Sep 2020 06:06:31 GMT, Kim Barrett wrote: >> Please review this small patch to enable the OSX build using Xcode 12.0. >> >> Thanks, >> Paul > > src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line 129: > >> 127: NSColor* result = nil; >> 128: >> 129: if