Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-10-05 Thread Sergey Bylokhov
Addepalli Cc: Ajit Ghaisas ; Shashidhara Veerabhadraiah ; awt-dev@openjdk.java.net Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. Hi, Krishna. Why did you update the test? Before the fix the robot used the middle of the first element

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-10-04 Thread Krishna Addepalli
-dev@openjdk.java.net Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. Hi, Krishna. Why did you update the test? Before the fix the robot used the middle of the first element, but after the fix it will click on the first pixel of the first

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-09-30 Thread Sergey Bylokhov
To: Krishna Addepalli <mailto:krishna.addepa...@oracle.com>>; Ajit Ghaisas mailto:ajit.ghai...@oracle.com>>; Shashidhara Veerabhadraiah <mailto:shashidhara.veerabhadra...@oracle.com>>; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net> Subject: Re: [12]RFR : JD

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-09-21 Thread Krishna Addepalli
t;> -Original Message- >> From: Sergey Bylokhov >> Sent: Tuesday, August 14, 2018 7:52 AM >> To: Krishna Addepalli ; Ajit Ghaisas >> ; Shashidhara Veerabhadraiah >> ; awt-dev@openjdk.java.net >> Subject: Re: [12]RFR : JDK-8014503: AWT Choice implemen

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-08-23 Thread Sergey Bylokhov
18 7:52 AM To: Krishna Addepalli ; Ajit Ghaisas ; Shashidhara Veerabhadraiah ; awt-dev@openjdk.java.net Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. On 13/08/2018 11:06, Krishna Addepalli wrote: The fix I propose is modeled afte

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-08-20 Thread Krishna Addepalli
it Ghaisas ; Shashidhara Veerabhadraiah ; awt-dev@openjdk.java.net Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. On 13/08/2018 11:06, Krishna Addepalli wrote: > The fix I propose is modeled after the code in Windows, which

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-08-13 Thread Sergey Bylokhov
On 13/08/2018 11:06, Krishna Addepalli wrote: The fix I propose is modeled after the code in Windows, which tracks items by their selected index. The code in Mac is storing currently selected object, which could raise the question about which object to select next, when the selected object is

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-08-13 Thread Krishna Addepalli
}); } } Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, July 5, 2018 8:10 PM To: Krishna Addepalli ; Ajit Ghaisas ; Shashidhara Veerabhadraiah ; awt-dev@openjdk.java.net Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-07-05 Thread Sergey Bylokhov
awt-dev@openjdk.java.net> *Subject:* RE: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. Hi Ajit, I don’t think we can use ‘skipPostMessage’ for this check for the following reasons: 1.‘skipPostMessage’ is intended to filter out item unse

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-07-04 Thread Krishna Addepalli
Veerabhadraiah; HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. Hi Ajit, I don't think we can use 'skipPostMessage' for this check for the following r

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-07-03 Thread Ajit Ghaisas
INK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. Can we use existing 'skipPostMessage' member for this check instead of introducing additional member in LW

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-07-03 Thread Krishna Addepalli
To: Shashidhara Veerabhadraiah ; Krishna Addepalli ; awt-dev@openjdk.java.net Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. Can we use existing 'skipPostMessage' member for this check instead of introducing additional member in LWChoicePeer

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-07-03 Thread Ajit Ghaisas
: Shashidhara Veerabhadraiah Sent: Monday, July 2, 2018 11:30 PM To: Krishna Addepalli mailto:krishna.addepa...@oracle.com"krishna.addepa...@oracle.com>; HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementati

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-07-03 Thread Shashidhara Veerabhadraiah
hashidhara Veerabhadraiah ; awt-dev@openjdk.java.net Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. Hi Shashi, Thanks for the review. Here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev01/ As for the te

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-07-02 Thread Krishna Addepalli
To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. Hi Krishna, Below are the comments on the fix that you made. 1. Based on the getSelectedIndex(), I think the selectedIndex should

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-07-02 Thread Shashidhara Veerabhadraiah
: JDK-8014503: AWT Choice implementation should be made consistent across platforms. Hi All, Please review a fix for JDK-8014503: https://bugs.openjdk.java.net/browse/JDK-8014503 Webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev00/ On Windows, the default behavior has been

[12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

2018-07-02 Thread Krishna Addepalli
Hi All, Please review a fix for JDK-8014503: https://bugs.openjdk.java.net/browse/JDK-8014503 Webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev00/ On Windows, the default behavior has been changed to not send an ItemEvent, if the same item is selected again, whereas this was