Thanks!
On 3/14/2016 12:12 PM, Yuri Nesterenko wrote:
+1
-yan
On 03/11/2016 06:05 PM, Alexander Scherbatiy wrote:
The test looks good to me.
Thanks,
Alexandr.
On 11/03/16 16:19, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the explanation. Could you please review the updated
+1
-yan
On 03/11/2016 06:05 PM, Alexander Scherbatiy wrote:
The test looks good to me.
Thanks,
Alexandr.
On 11/03/16 16:19, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the explanation. Could you please review the updated test?
No, I simply believe that Alexandr is right :)
Thanks,
Alexander
On 3/11/2016 6:32 PM, Sergey Bylokhov wrote:
On 11.03.16 15:19, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the explanation. Could you please review the updated test?
The test looks good to me.
Thanks,
Alexandr.
On 11/03/16 16:19, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the explanation. Could you please review the updated test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/
The icon size was reduced.
Thanks,
Alexander
On
Hello Alexandr,
Thank you for the explanation. Could you please review the updated test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/
The icon size was reduced.
Thanks,
Alexander
On 3/11/2016 3:14 PM, Alexander Scherbatiy wrote:
On 10/03/16 16:22, Alexander Stepanov wrote:
Hello
On 10/03/16 16:22, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the comment. Please note that:
1. this hard-coded icon size for the tab is seemingly used only for
Mac OS X L, please see
http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png
(for other L the
Could you please review the updated version of the test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/
- should pass on OS X after JDK-8151303 fix. 16x16 and 32x32 icons are
used for the tab; the loop over L added.
Thanks,
Alexander
On 3/10/2016 3:22 PM, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the comment. Please note that:
1. this hard-coded icon size for the tab is seemingly used only for Mac
OS X L, please see
http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png
(for other L the tab's size is adjusted to the icon's size. L are:
On 03/03/16 18:45, Alexander Stepanov wrote:
Could you please review the updated version of the test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.01
Line
106 tabbedPane.addTab("", icon, p);
was replaced with
109 tabbedPane.addTab("", p);
110
They are used for the further coordinates obtaining (on OS X the icon
sizes are not equal for the buttons and the tabbed pane - please see the
screenshot attached to JDK-8151060):
Please see lines 187-189:
187 Component tc = tabbedPane.getTabComponentAt(1);
188 x =
Can you please clarify these lines:
117 tabbedPane.addTab("", new JPanel());
118 tabbedPane.setTabComponentAt(1, new JLabel());
On 09.03.16 18:48, Alexander Stepanov wrote:
Hello, Sergey,
Please see the updated version of the test:
Hello, Sergey,
Please see the updated version of the test:
http://cr.openjdk.java.net/~avstepan/8150724/webrev.02/
(covers JDK-8151303 as well).
> I suggest to add these lines to the test instead of replace the old lines
done.
please see "@requires tag" - for now it will stop test run on OS
The test should be updated to cover the related issue
https://bugs.openjdk.java.net/browse/JDK-8151303
Regards,
Alexander
On 3/4/2016 1:15 PM, Alexander Stepanov wrote:
Hello, Sergey,
We have JLabel(icon) already in the test, and we cannot have both
these cases at the same tab. Moreover, we
Hello, Sergey,
We have JLabel(icon) already in the test, and we cannot have both these
cases at the same tab. Moreover, we can in principle use some other
components as an argument of 'setTabComponentAt', but I'm not sure that
these cases have some novelty.
So my suggestion is to can
Hi, Alexander.
I suggest to add these lines to the test instead of replace the old
lines. The test will pass after the fix for 8151060.
On 03.03.16 17:45, Alexander Stepanov wrote:
Could you please review the updated version of the test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.01
Could you please review the updated version of the test?
http://cr.openjdk.java.net/~avstepan/8150724/webrev.01
Line
106 tabbedPane.addTab("", icon, p);
was replaced with
109 tabbedPane.addTab("", p);
110 tabbedPane.setTabComponentAt(0, new JLabel(icon));
- in such a
Hello Sergey,
It fails because of
https://bugs.openjdk.java.net/browse/JDK-8151060
(plus we need here some tricky check for resolution by the analogy with
8150258 because of JDK-8150844).
Thanks,
Alexander
On 2/26/2016 4:25 PM, Sergey Bylokhov wrote:
Hi, Alexander.
The test failed on osx
Hi, Alexander.
The test failed on osx 10.11 + retina. Is it expected?
On 26.02.16 15:53, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150724 ?
Just a single test
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8150724 ?
Just a single test added.
Thanks,
Alexander
19 matches
Mail list logo
