Re: [9] Review Request: 8151773 [macosx] TrayIcon.imageAutoSize property is ignored

2016-03-31 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 15/03/16 04:54, Sergey Bylokhov wrote: Hello, Please review the small fix for jdk9. According to specification if imageAutoSize property was set to true the image should be the stretched or shrunk to fit the tray icon space. But on OSX this flag

Re: [9] Review Request: 8151773 [macosx] TrayIcon.imageAutoSize property is ignored

2016-03-23 Thread Sergey Bylokhov
On 23.03.16 11:09, Semyon Sadetsky wrote: What do you mean by "by selection of the image dimensions and content"? The user cannot select the size of the resulted image because the image occupy the whole tray and scales if necessary, and the color is defined already as "white rectangle in a blue m

Re: [9] Review Request: 8151773 [macosx] TrayIcon.imageAutoSize property is ignored

2016-03-23 Thread Semyon Sadetsky
On 3/22/2016 6:13 PM, Sergey Bylokhov wrote: On 22.03.16 9:54, Semyon Sadetsky wrote: The test instruction: > Please check if both of them have correct size and > the same colouring (white rectagle in a blue mount). In this case please push "Pass". It is unclear how does it test the fix? C

Re: [9] Review Request: 8151773 [macosx] TrayIcon.imageAutoSize property is ignored

2016-03-22 Thread Sergey Bylokhov
On 22.03.16 9:54, Semyon Sadetsky wrote: The test instruction: > Please check if both of them have correct size and > the same colouring (white rectagle in a blue mount). In this case please push "Pass". It is unclear how does it test the fix? Correct/incorrect size criteria should be reveale

Re: [9] Review Request: 8151773 [macosx] TrayIcon.imageAutoSize property is ignored

2016-03-21 Thread Semyon Sadetsky
The test instruction: > Please check if both of them have correct size and > the same colouring (white rectagle in a blue mount). In this case please push "Pass". It is unclear how does it test the fix? Correct/incorrect size criteria should be revealed better. However, it is hard to count pix

[9] Review Request: 8151773 [macosx] TrayIcon.imageAutoSize property is ignored

2016-03-14 Thread Sergey Bylokhov
Hello, Please review the small fix for jdk9. According to specification if imageAutoSize property was set to true the image should be the stretched or shrunk to fit the tray icon space. But on OSX this flag is ignored in the native code. In the fix this flag is taken into account, if it was s