Re: [9] Review request for 8017112 JTabbedPane components have inconsistent accessibility tree

2016-04-29 Thread Sergey Bylokhov
Looks fine, I assume that if the parent is Accessible then it has non-null accessible context. On 29.04.16 19:54, Pete Brunet wrote: Looks good Alexandr. On 4/29/16 11:42 AM, Alexander Scherbatiy wrote: Hello, Cold you review the updated fix:

Re: [9] Review request for 8017112 JTabbedPane components have inconsistent accessibility tree

2016-04-29 Thread Pete Brunet
Looks good Alexandr. On 4/29/16 11:42 AM, Alexander Scherbatiy wrote: > > Hello, > > Cold you review the updated fix: > http://cr.openjdk.java.net/~alexsch/8017112/webrev.01 > > The (this instanceof Accessible) is removed from the fix. > > Thanks, > Alexandr. > > On 29/04/16 01:37,

Re: [9] Review request for 8017112 JTabbedPane components have inconsistent accessibility tree

2016-04-29 Thread Alexander Scherbatiy
Hello, Cold you review the updated fix: http://cr.openjdk.java.net/~alexsch/8017112/webrev.01 The (this instanceof Accessible) is removed from the fix. Thanks, Alexandr. On 29/04/16 01:37, Sergey Bylokhov wrote: Hi, Alexander. Is the "instance of" check is necessary at the

Re: [9] Review request for 8017112 JTabbedPane components have inconsistent accessibility tree

2016-04-28 Thread Sergey Bylokhov
Hi, Alexander. Is the "instance of" check is necessary at the beginning of the method? Usually we use the "instance of" to get AccessibleContext in code like this: AccessibleContext accContext = ((Accessible)this).getAccessibleContext(); But it seems we have not the cast here, or it is necessary

[9] Review request for 8017112 JTabbedPane components have inconsistent accessibility tree

2016-04-28 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8017112 webrev: http://cr.openjdk.java.net/~alexsch/8017112/webrev.00 Component.getAccessibleIndexInParent() takes parent from components hierarchy which can be different from the accessibility tree