Re: [9] Review request for 8136999[macosx] NSException and NPE in a crash test

2015-10-21 Thread Sergey Bylokhov
Hi, Alexander. Can you please clarify why this event flushing is necessary. As far as I understand we have this sequence of calls: performDragOperation: -> handleDropMessage -> postDropTargetEvent(,DISPATCH_SYNC) -> postEvent to EDT -> block Appkit untill event is not dispa

Re: [9] Review request for 8136999[macosx] NSException and NPE in a crash test

2015-10-14 Thread Semyon Sadetsky
Hi Alexander, The fix looks good. --Semyon On 10/7/2015 4:25 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8136999 webrev: http://cr.openjdk.java.net/~alexsch/8136999/webrev.00 The test sets drop target to null in the dr

[9] Review request for 8136999[macosx] NSException and NPE in a crash test

2015-10-07 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8136999 webrev: http://cr.openjdk.java.net/~alexsch/8136999/webrev.00 The test sets drop target to null in the drop handling which leads to the drop target resources disposing. The fix moves events flushing