Re: [9] Review request for 8151189: Possible getAppContext() NPE in java.awt.Desktop and java.awt.Taskbar

2016-11-21 Thread Sergey Bylokhov
On 16.11.16 0:16, Phil Race wrote: A "main" appcontext will be created if you are a standalone app, but not if running in webstart (although the means of determining that is somewhat hokey) :- if (numAppContexts.get() == 0) { if (System.getProperty("javaplugin.versi

Re: [9] Review request for 8151189: Possible getAppContext() NPE in java.awt.Desktop and java.awt.Taskbar

2016-11-20 Thread Alexander Zvegintsev
I forgot to save an instance of the Desktop class to the static variable. http://cr.openjdk.java.net/~azvegint/jdk/9/8151189/01/ Thanks, Alexander. On 11/16/16 12:16 AM, Phil Race wrote: A "main" appcontext will be created if you are a standalone app, but not if running in webstart (although t

Re: [9] Review request for 8151189: Possible getAppContext() NPE in java.awt.Desktop and java.awt.Taskbar

2016-11-15 Thread Phil Race
A "main" appcontext will be created if you are a standalone app, but not if running in webstart (although the means of determining that is somewhat hokey) :- if (numAppContexts.get() == 0) { if (System.getProperty("javaplugin.version") == null && System.getProperty

Re: [9] Review request for 8151189: Possible getAppContext() NPE in java.awt.Desktop and java.awt.Taskbar

2016-11-15 Thread Phil Race
So are you saying we will never call this from the Toolkit thread, so provably there will never be an NPE ? Seems we have had a ton of NPE bugs from getAppContext() returning null so I am not so confident about that. -phil. On 11/15/2016 10:44 AM, Sergey Bylokhov wrote: I guess this should be

Re: [9] Review request for 8151189: Possible getAppContext() NPE in java.awt.Desktop and java.awt.Taskbar

2016-11-15 Thread Sergey Bylokhov
I guess this should be closed as not a defect. getAppContext() can return null if it will be called from the toolkit thread. If this method is called by the user then appcontext should not be null, additionally we should not cache this value in the static, so all other code will use this cached

Re: [9] Review request for 8151189: Possible getAppContext() NPE in java.awt.Desktop and java.awt.Taskbar

2016-11-15 Thread Semyon Sadetsky
+1 --Semyon On 15.11.2016 20:38, Phil Race wrote: +1 -phil. On 11/15/2016 08:24 AM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8151189/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8151189

Re: [9] Review request for 8151189: Possible getAppContext() NPE in java.awt.Desktop and java.awt.Taskbar

2016-11-15 Thread Phil Race
+1 -phil. On 11/15/2016 08:24 AM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8151189/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8151189

[9] Review request for 8151189: Possible getAppContext() NPE in java.awt.Desktop and java.awt.Taskbar

2016-11-15 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8151189/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8151189 -- Thanks, Alexander.