Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

OK, so +1 -phil On 5/12/16, 12:02 AM, Alexander Scherbatiy wrote: On 12/05/16 03:18, Philip Race wrote: Why doesn't the test need now @modules java.desktop/sun.awt The test does not create a SoftCache or cast to it. It iterates over some object references graph and just skip the case

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

On 11 May 2016, at 22:59, Mandy Chung wrote: > >> On May 11, 2016, at 2:55 PM, Alexander Scherbatiy >> wrote: >> >> On 12/05/16 01:50, Phil Race wrote: >>> Alexander ... I am concurrently deleting GThreadHelper (see webrev I just >>>

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

On 12/05/16 03:18, Philip Race wrote: Why doesn't the test need now @modules java.desktop/sun.awt The test does not create a SoftCache or cast to it. It iterates over some object references graph and just skip the case where a reference class type name equals to

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

Why doesn't the test need now @modules java.desktop/sun.awt ? -phil. On 5/11/16, 2:59 PM, Mandy Chung wrote: On May 11, 2016, at 2:55 PM, Alexander Scherbatiy wrote: On 12/05/16 01:50, Phil Race wrote: Alexander ... I am concurrently deleting GThreadHelper

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

> On May 11, 2016, at 2:55 PM, Alexander Scherbatiy > wrote: > > On 12/05/16 01:50, Phil Race wrote: >> Alexander ... I am concurrently deleting GThreadHelper (see webrev I just >> sent out) >> which is covered by a separate bug so please revert that part of

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

Alexander ... I am concurrently deleting GThreadHelper (see webrev I just sent out) which is covered by a separate bug so please revert that part of the fix. -phil. On 5/11/2016 2:43 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix:

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8154539/webrev.01 - The test/com/sun/jdi/ReferrersTest.java test is updated to use sun.awt.SoftCache - The sun.misc.GThreadHelper class is moved to the sun.awt package in the java.desktop module The

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

+1 assuming this is really the only use .. You are updating the module-info and although there is one other class in there used by java.desktop that is OK I believe since it is only used from JNI. Also I will be sending out a webrev for that one soon. We should some day revisit whether this

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

On 11 May 2016, at 21:15, Mandy Chung wrote: > >> On May 11, 2016, at 1:07 PM, Alexander Scherbatiy >> wrote: >> >> >> Hello, >> >> Could you review the fix: >> bug: https://bugs.openjdk.java.net/browse/JDK-8154539 >> webrev:

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

> On May 11, 2016, at 1:07 PM, Alexander Scherbatiy > wrote: > > > Hello, > > Could you review the fix: > bug: https://bugs.openjdk.java.net/browse/JDK-8154539 > webrev: http://cr.openjdk.java.net/~alexsch/8154539/webrev.00 > > This is a request from the

[9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8154539 webrev: http://cr.openjdk.java.net/~alexsch/8154539/webrev.00 This is a request from the jigsaw team to get rid of the dependency to jdk.unsupported module from the java.desktop module. The fix