Re: [9] Review request for 8176490: [macosx] Sometimes NSWindow.isZoomed hangs

ers obtain Java from https://java.com/ Thanks Reto Von: dmitry markov An: Reto Merz Kopie: 'Alexander Zvegintsev' , 'Sergey Bylokhov' , 'awt-dev' Gesendet: 28.03.2017 20:41 Betreff: Re: [9] Review request for 8176490: [macosx] Sometimes

Re: [9] Review request for 8176490: [macosx] Sometimes NSWindow.isZoomed hangs

Hi Reto, JDK-8169589 was integrated into 8u121-b31. What build of 8u121 did you use for testing? Also JDK-8169589 was included into 8u131 (upcoming April release). I am afraid we do not have

Re: [9] Review request for 8176490: [macosx] Sometimes NSWindow.isZoomed hangs

According to the comment in JDK-8176490 the regression was introduced with JDK-8169589. And JDK-8169589 stats that this bug was fixed in 8u121 (among other). But I am not able to reproduce the JDK-8176490 issue with WindowDeadlockTest [1] and 8u121 on macOS 10.12.3. But the test hangs with 8u152

Re: [9] Review request for 8176490: [macosx] Sometimes NSWindow.isZoomed hangs

Looks fine to me too. Thanks, Alexander. On 27/03/2017 08:35, dmitry markov wrote: Thank you, Sergey! Looking for the second +1 from someone else. Thank you in advance, Dmitry On 24/03/2017 21:01, Sergey Bylokhov wrote: Looks fine. Hi Sergey, Thank you for the review. Actually deliverMoveR

Re: [9] Review request for 8176490: [macosx] Sometimes NSWindow.isZoomed hangs

Thank you, Sergey! Looking for the second +1 from someone else. Thank you in advance, Dmitry On 24/03/2017 21:01, Sergey Bylokhov wrote: Looks fine. Hi Sergey, Thank you for the review. Actually deliverMoveResizeEvent() is always called once a window is displayed. If the window is created us

Re: [9] Review request for 8176490: [macosx] Sometimes NSWindow.isZoomed hangs

Looks fine. > > Hi Sergey, > Thank you for the review. > > Actually deliverMoveResizeEvent() is always called once a window is > displayed. If the window is created using max W/H of the screen, the function > will be invoked and isZoomed field will contain the correct value. I have > just che

Re: [9] Review request for 8176490: [macosx] Sometimes NSWindow.isZoomed hangs

Hi Sergey, Thank you for the review. Actually deliverMoveResizeEvent() is always called once a window is displayed. If the window is created using max W/H of the screen, the function will be invoked and isZoomed field will contain the correct value. I have just checked that. Thanks, Dmitry > O

Re: [9] Review request for 8176490: [macosx] Sometimes NSWindow.isZoomed hangs

Hi, Dmitry. Can you please check that the fix does not break the situation when the frame is created using max W/H of the screen. In this case the old zoom logic return true, is it possible that the new logic will return false since deliverMoveResizeEvent will not be called? > > > Hello, > >

[9] Review request for 8176490: [macosx] Sometimes NSWindow.isZoomed hangs

Hello, Could you review a fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8176490 webrev: http://cr.openjdk.java.net/~dmarkov/8176490/webrev.00/ Problem description: On OSX AppKit thread and EDT or main application thread might be blocked when a child window