Re: [9] Review request for JDK-7156316: [macosx] Ctrl+Space does generate Unknown keychar

2016-07-04 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/3/2016 10:08 PM, Manajit Halder wrote: Hi Alexandr, Thank you for your review comment. I have changed the if condition to chars.trim().isEmpty(). Please review the modified code: http://cr.openjdk.java.net/~mhalder/7156316/webrev.01/

Re: [9] Review request for JDK-7156316: [macosx] Ctrl+Space does generate Unknown keychar

2016-07-03 Thread Manajit Halder
Hi Alexandr, Thank you for your review comment. I have changed the if condition to chars.trim().isEmpty(). Please review the modified code: http://cr.openjdk.java.net/~mhalder/7156316/webrev.01/ Thanks, Manajit > On 30-Jun-2016, at

Re: [9] Review request for JDK-7156316: [macosx] Ctrl+Space does generate Unknown keychar

2016-06-30 Thread Alexander Scherbatiy
On 27/06/16 21:57, Manajit Halder wrote: Hi All, Kindly review the fix for JDK9. *Bug*: https://bugs.openjdk.java.net/browse/JDK-7156316 _ _ *Webrev*: http://cr.openjdk.java.net/~mhalder/7156316/webrev.00/ *Issue: * [macosx]

[9] Review request for JDK-7156316: [macosx] Ctrl+Space does generate Unknown keychar

2016-06-27 Thread Manajit Halder
Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-7156316 Webrev: http://cr.openjdk.java.net/~mhalder/7156316/webrev.00/ Issue: [macosx]