Re: [9] Review request for JDK-8163270: [macosx] Robot(gc) issue on dual-screen system.

2016-09-14 Thread Ajit Ghaisas
Test looks good after suggested cleanup. Regards, Ajit -Original Message- From: Sergey Bylokhov Sent: Wednesday, September 14, 2016 11:38 PM To: Manajit Halder Cc: Rajeev Chamyal; Ajit Ghaisas; awt-dev@openjdk.java.net Subject: Re: [9] Review request for JDK-8163270: [macosx] Robot(gc

Re: [9] Review request for JDK-8163270: [macosx] Robot(gc) issue on dual-screen system.

2016-09-14 Thread Sergey Bylokhov
Looks fine, thanks! On 14.09.16 14:43, Manajit Halder wrote: Hi Sergey, Thank you for your review comment. Code is modified and cleaned. Please review the modified webrev. http://cr.openjdk.java.net/~mhalder/8163270/webrev.01/ Thanks, Manajit On 09-Sep-2016, at 10:08 pm, Sergey Bylokhov mai

Re: [9] Review request for JDK-8163270: [macosx] Robot(gc) issue on dual-screen system.

2016-09-14 Thread Manajit Halder
Hi Sergey, Thank you for your review comment. Code is modified and cleaned. Please review the modified webrev. http://cr.openjdk.java.net/~mhalder/8163270/webrev.01/ Thanks, Manajit > On 09-Sep-2016, at 10:08 pm, Sergey Bylokhov > wrot

Re: [9] Review request for JDK-8163270: [macosx] Robot(gc) issue on dual-screen system.

2016-09-09 Thread Sergey Bylokhov
Hi, Manajit. I recognized that the test can be cleaned a little bit. We can move the code from the init() to main and remove all other unnecessary stuff: TestPassedException, pass(), setTimeoutTo(), etc. On 09.09.16 8:23, Manajit Halder wrote: Hi All, Kindly review the fix for JDK9. *Bug*:

[9] Review request for JDK-8163270: [macosx] Robot(gc) issue on dual-screen system.

2016-09-08 Thread Manajit Halder
Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8163270 Webrev: http://cr.openjdk.java.net/~mhalder/8163270/webrev.00/ Issue: [macosx] Robot(gc) issue on dual-screen system. Cause: Calculation of x coordinate value was wrong for the mouse cursor in th