Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled [v2]

2021-07-23 Thread Kevin Rushforth
On Fri, 23 Jul 2021 05:49:25 GMT, Alexander Zuev wrote: >> Fixed the version string parsing to work correctly on macOS 11.x and beyond > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Demoved isBigSurOrAbove variable that

Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled [v2]

2021-07-23 Thread Prasanta Sadhukhan
On Fri, 23 Jul 2021 05:49:25 GMT, Alexander Zuev wrote: >> Fixed the version string parsing to work correctly on macOS 11.x and beyond > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Demoved isBigSurOrAbove variable that

Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled [v2]

2021-07-22 Thread Alexander Zuev
On Fri, 23 Jul 2021 04:16:10 GMT, Prasanta Sadhukhan wrote: > This is not required..Need to be removed. Done. - PR: https://git.openjdk.java.net/jdk17/pull/269

Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled [v2]

2021-07-22 Thread Alexander Zuev
> Fixed the version string parsing to work correctly on macOS 11.x and beyond Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Demoved isBigSurOrAbove variable that was never used in the code - Changes: - all:

Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled

2021-07-22 Thread Alexander Zuev
On Fri, 23 Jul 2021 04:18:42 GMT, Prasanta Sadhukhan wrote: > Since existing currentMacOSXVersionMatchesGivenVersionRange() is changed, did > you test in osx 10.15 or below to see current functionality is ok? I have tested the public methods of this class with simulated version strings for

Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled

2021-07-22 Thread Prasanta Sadhukhan
On Thu, 22 Jul 2021 16:25:40 GMT, Alexander Zuev wrote: > Fixed the version string parsing to work correctly on macOS 11.x and beyond Since existing currentMacOSXVersionMatchesGivenVersionRange() is changed, did you test in osx 10.15 or below to see current functionality is ok? ALso, please

Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled

2021-07-22 Thread Kevin Rushforth
On Thu, 22 Jul 2021 16:25:40 GMT, Alexander Zuev wrote: > Fixed the version string parsing to work correctly on macOS 11.x and beyond Looks good. I also tested it on macOS 11.5 and verified that the test case fails (is rendered incorrectly) without your fix and passes with your fix. @prsadhuk

[jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled

2021-07-22 Thread Alexander Zuev
Fixed the version string parsing to work correctly on macOS 11.x and beyond - Commit messages: - 8269984: [macos] JTabbedPane title looks like disabled Changes: https://git.openjdk.java.net/jdk17/pull/269/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=269=00 Issue: