Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

2015-11-25 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. 25.11.2015 16:29, Sergey Bylokhov пишет: Looks fine. On 25.11.15 11:18, Semyon Sadetsky wrote: On 11/12/2015 2:02 AM, Sergey Bylokhov wrote: Isn't this is a typo in the MouseMovedTest.java? : 42 if (SystemTray.isSupported()) { 43

Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

2015-11-25 Thread Yuri Nesterenko
Now we should carefully merge them with Jigsaw version. -yan On 11/25/2015 11:18 AM, Semyon Sadetsky wrote: On 11/12/2015 2:02 AM, Sergey Bylokhov wrote: Isn't this is a typo in the MouseMovedTest.java? : 42 if (SystemTray.isSupported()) { 43 return; 44 }

Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

2015-11-25 Thread Semyon Sadetsky
On 11/12/2015 2:02 AM, Sergey Bylokhov wrote: Isn't this is a typo in the MouseMovedTest.java? : 42 if (SystemTray.isSupported()) { 43 return; 44 } Yes it is a mistake. Thanks. The updated webrev: http://cr.openjdk.java.net/~ssadetsky/8081457/webrev.02/

Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

2015-11-25 Thread Sergey Bylokhov
Looks fine. On 25.11.15 11:18, Semyon Sadetsky wrote: On 11/12/2015 2:02 AM, Sergey Bylokhov wrote: Isn't this is a typo in the MouseMovedTest.java? : 42 if (SystemTray.isSupported()) { 43 return; 44 } Yes it is a mistake. Thanks. The updated webrev:

Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

2015-11-11 Thread Sergey Bylokhov
Isn't this is a typo in the MouseMovedTest.java? : 42 if (SystemTray.isSupported()) { 43 return; 44 } Please take a look to the similar issue: JDK-8117886 On 06.11.15 16:07, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On

Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

2015-11-06 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 10/28/2015 4:05 PM, Alexander Zvegintsev wrote: The fix looks good to me. Thanks, Alexander. On 10/28/2015 03:01 PM, Semyon Sadetsky wrote: On 10/14/2015 3:50 PM, Alexander Zvegintsev wrote: Hi Semyon, As I can see there are a lot

Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

2015-10-14 Thread Alexander Zvegintsev
Hi Semyon, As I can see there are a lot similar checks in tests for OEL7, ideally it should be checked against gnome-shell(probably from DESKTOP_SESSION env variable, or check for running gnome-shell process), but I am OK with the current check. Could you please extract this check to some

[9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

2015-10-13 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8081457 webrev: http://cr.openjdk.java.net/~ssadetsky/8081457/webrev.00/ In OEL7 the system tray was changed a lot. It is totally hidden by default and its tray icons only capable to receive click events. Mouse