m>
> Cc: Sergey Bylokhov <sergey.bylok...@oracle.com>; awt-
> d...@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
> issues in awt coding
>
> I didn't eyeball what you changed but JPRT is now happy.
&
.@sap.com>; Sergey Bylokhov
<sergey.bylok...@oracle.com>
Cc: awt-dev@openjdk.java.net; 2d-dev<2d-...@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
issues in awt coding
I tried it .. and just as well I did. It fails in the crypto code on Mac.
jdk/src/jd
ava.net>
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
> issues in awt coding
>
> I tried it .. and just as well I did. It fails in the crypto code on Mac.
>
> jdk/src/jdk.crypto.ec/share/native/libsunec/impl/ec.c:261:12: error:
> expression which evaluates to zero
]
Sent: Friday, December 02, 2016 8:46 PM
To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Sergey Bylokhov
<sergey.bylok...@oracle.com>
Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
issues in awt codi
;; Sergey Bylokhov
> <sergey.bylok...@oracle.com>
> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
> issues in awt coding
>
> I had no other comments, except that it would be good to be sure
>
-...@openjdk.java.net>; security-
d...@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues
in awt coding
Sorry. it is
ops->GetRasInfo(env, ops, lockInfo);
that initialises it ..
That is still before the dereference
Anyway, what was the reaso
r...@oracle.com>
> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; security-
> d...@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues
> in awt coding
>
> Sorry. it is
> ops->GetRasInfo(env, ops, lockInfo);
> t
ava.net>; security-
d...@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues
in awt coding
Hi Goetz,
DataBufferNative.c
Using uninitialized value lockInfo.rasBase when calling DBN_GetPixelPointer.
75 lockInfo.resBase = NULL;
Did you actually compi
(Am I correct that your openJdk name is Vinnie?)
> >
> >
> >
> > -Original Message-
> > From: Vincent Ryan
> > [mailto:vincent.x.r...@oracle.com]
> > Sent: Mittwoch, 30.
rgey.bylok...@oracle.com>; Lindenmaier, Goetz
> <goetz.lindenma...@sap.com>; Vincent Ryan <vincent.x.r...@oracle.com>
> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; security-
> d...@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] RF
Langer, Christoph
> Sent: Mittwoch, 30. November 2016 20:47
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
> Cc: awt-dev@openjdk.java.net; security-...@openjdk.java.net; 2d-
> d...@openjdk.java.net; Vincent Ryan <vincent.x.r...@oracle.com>
> Subject: RE: RFR(M): 817052
that your openJdk name is Vinnie?)
-Original Message-
From: Vincent Ryan [mailto:vincent.x.r...@oracle.com]
Sent: Mittwoch, 30. November 2016 14:53
To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
Cc: awt-dev@openjdk.java.net; security-...@openjdk.java.net
Subject: Re: RFR(M): 8170525
.@sap.com>
> Cc: awt-dev@openjdk.java.net; security-...@openjdk.java.net
> Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding
>
> Note that I have reviewed only the ECC/PKCS11 changes.
> You’ll need a JDK 9 reviewer from awt-dev for your remaining changes.
>
> There i
ap.com>
Cc: awt-dev@openjdk.java.net; security-...@openjdk.java.net
Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding
Hello Goetz,
Please modify the bug summary to reference ECC too.
Your ECC changes look fine but the ‘Last Modified Date’ line in the
4 source
code headers will nee
gt;> From: Vincent Ryan [mailto:vincent.x.r...@oracle.com]
>> Sent: Mittwoch, 30. November 2016 14:53
>> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
>> Cc: awt-dev@openjdk.java.net; security-...@openjdk.java.net
>> Subject: Re: RFR(M): 8170525: Fix minor
Hello Goetz,
Please modify the bug summary to reference ECC too.
Your ECC changes look fine but the ‘Last Modified Date’ line in the 4 source
code headers will need to be updated/added.
BTW p11_mutex.c is listed below but appears to be missing from the webrev.
Thanks.
> On 30 Nov 2016, at
enmaier, Goetz
> Sent: Mittwoch, 30. November 2016 16:41
> To: Vincent Ryan <vincent.x.r...@oracle.com>
> Cc: awt-dev@openjdk.java.net; security-...@openjdk.java.net
> Subject: RE: RFR(M): 8170525: Fix minor issues in awt coding
>
> Hi Vincent,
>
> thanks for the quit rev
t;goetz.lindenma...@sap.com>
Cc: awt-dev@openjdk.java.net; security-...@openjdk.java.net
Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding
Hello Goetz,
Please modify the bug summary to reference ECC too.
Your ECC changes look fine but the ‘Last Modified Date’ line in the
4 sourc
gt;
Cc: awt-dev@openjdk.java.net; security-...@openjdk.java.net
Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding
Hello Goetz,
Please modify the bug summary to reference ECC too.
Your ECC changes look fine but the ‘Last Modified Date’ line in the 4 source
code headers will need to be u
dk.java.net; security-...@openjdk.java.net
> Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding
>
> Hello Goetz,
>
> Please modify the bug summary to reference ECC too.
> Your ECC changes look fine but the ‘Last Modified Date’ line in the 4 source
> code headers will need
Hi,
I'd like to propose a row of smaller fixes where code is noted down a bit
questionable.
SAP's quality process requires that we fix these in our internal delivery, and I
Would like to share my fixes with openJdk. Some of these fixes are of more
theoretical nature as how I understand the code
21 matches
Mail list logo
