Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS) [v5]

2021-06-17 Thread Phil Race
On Thu, 17 Jun 2021 20:49:59 GMT, Alexander Zvegintsev wrote: >> This fix is to explicitly specify that `Taskbar::getIconImage` may return an >> object different from passed to `Taskbar::setIconImage`. >> >> Actually it is always returns a different object on macOS(the only OS which >> suppor

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS) [v4]

2021-06-17 Thread Alexander Zvegintsev
On Thu, 17 Jun 2021 20:31:07 GMT, Phil Race wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> header fix > > src/java.desktop/share/classes/java/awt/Taskbar.java line 341: > >> 339: /** >> 340: * Ob

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS) [v5]

2021-06-17 Thread Alexander Zvegintsev
> This fix is to explicitly specify that `Taskbar::getIconImage` may return an > object different from passed to `Taskbar::setIconImage`. > > Actually it is always returns a different object on macOS(the only OS which > supports this feature), but I want to save some options if we decide to > r

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS) [v4]

2021-06-17 Thread Phil Race
On Thu, 17 Jun 2021 17:33:48 GMT, Alexander Zvegintsev wrote: >> This fix is to explicitly specify that `Taskbar::getIconImage` may return an >> object different from passed to `Taskbar::setIconImage`. >> >> Actually it is always returns a different object on macOS(the only OS which >> suppor

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS) [v4]

2021-06-17 Thread Alexander Zvegintsev
> This fix is to explicitly specify that `Taskbar::getIconImage` may return an > object different from passed to `Taskbar::setIconImage`. > > Actually it is always returns a different object on macOS(the only OS which > supports this feature), but I want to save some options if we decide to > r

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS) [v3]

2021-06-17 Thread Alexander Zvegintsev
> This fix is to explicitly specify that `Taskbar::getIconImage` may return an > object different from passed to `Taskbar::setIconImage`. > > Actually it is always returns a different object on macOS(the only OS which > supports this feature), but I want to save some options if we decide to > r

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS) [v2]

2021-05-27 Thread Alexander Zvegintsev
On Wed, 26 May 2021 17:51:55 GMT, Alexander Zvegintsev wrote: >> This fix is to explicitly specify that `Taskbar::getIconImage` may return an >> object different from passed to `Taskbar::setIconImage`. >> >> Actually it is always returns a different object on macOS(the only OS which >> suppor

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS) [v2]

2021-05-26 Thread Alexander Zvegintsev
> This fix is to explicitly specify that `Taskbar::getIconImage` may return an > object different from passed to `Taskbar::setIconImage`. > > Actually it is always returns a different object on macOS(the only OS which > supports this feature), but I want to save some options if we decide to > r

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS)

2021-05-08 Thread Alexander Zvegintsev
On Fri, 7 May 2021 19:57:02 GMT, Phil Race wrote: > Leaving aside specification. what does an app really want this to return ? > Should we start from there ? We are returning current dock icon image from system. > Do we definitely not want to just hang on to whatever an application set so > we

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS)

2021-05-07 Thread Phil Race
On Mon, 29 Mar 2021 18:57:55 GMT, Alexander Zvegintsev wrote: > This fix is to explicitly specify that `Taskbar::getIconImage` may return an > object different from passed to `Taskbar::setIconImage`. > > Actually it is always returns a different object on macOS(the only OS which > supports th

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS)

2021-04-30 Thread Alexander Zvegintsev
On Mon, 29 Mar 2021 18:57:55 GMT, Alexander Zvegintsev wrote: > This fix is to explicitly specify that `Taskbar::getIconImage` may return an > object different from passed to `Taskbar::setIconImage`. > > Actually it is always returns a different object on macOS(the only OS which > supports th

Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS)

2021-03-30 Thread Alexander Zuev
On Mon, 29 Mar 2021 18:57:55 GMT, Alexander Zvegintsev wrote: > This fix is to explicitly specify that `Taskbar::getIconImage` may return an > object different from passed to `Taskbar::setIconImage`. > > Actually it is always returns a different object on macOS(the only OS which > supports th