Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows [v2]

2021-04-28 Thread Phil Race
On Wed, 28 Apr 2021 13:55:28 GMT, Alexander Scherbatiy wrote: >> PDFBox 1.8 uses >> [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) >> method with scaled g

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows [v2]

2021-04-28 Thread Sergey Bylokhov
On Wed, 28 Apr 2021 13:55:28 GMT, Alexander Scherbatiy wrote: >> PDFBox 1.8 uses >> [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) >> method with scaled g

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows [v2]

2021-04-28 Thread Alexander Scherbatiy
On Wed, 28 Apr 2021 13:55:28 GMT, Alexander Scherbatiy wrote: >> PDFBox 1.8 uses >> [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) >> method with scaled g

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows [v2]

2021-04-28 Thread Alexander Scherbatiy
> PDFBox 1.8 uses > [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) > method with scaled glyphs to print a text and PDF 2.0 uses > [Graphics2D.fill()](https:

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows

2021-04-27 Thread Phil Race
On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy wrote: > PDFBox 1.8 uses > [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) > method with scaled glyp

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows

2021-04-27 Thread Alexander Scherbatiy
On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy wrote: > PDFBox 1.8 uses > [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) > method with scaled glyp

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows

2021-04-26 Thread Phil Race
On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy wrote: > PDFBox 1.8 uses > [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) > method with scaled glyp

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows

2021-04-26 Thread Alexander Scherbatiy
On Sun, 25 Apr 2021 20:53:11 GMT, Sergey Bylokhov wrote: >> Would it be better to use isBlank() instead of isEmpty() to check a font >> family name is blank? >> >> if (family.isBlank()) { >> return false; >> } > > I think so. I changed the test SampleBow font family

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows

2021-04-25 Thread Sergey Bylokhov
On Fri, 23 Apr 2021 08:08:29 GMT, Alexander Scherbatiy wrote: >> src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java line 1160: >> >>> 1158: int rotation, float awScale) { >>> 1159: >>> 1160: if (family.isEmpty()) { >> >> Not sure that the n

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows

2021-04-23 Thread Alexander Scherbatiy
On Fri, 23 Apr 2021 07:02:45 GMT, Sergey Bylokhov wrote: >> PDFBox 1.8 uses >> [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) >> method with scaled glyphs

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows

2021-04-23 Thread Sergey Bylokhov
On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy wrote: > PDFBox 1.8 uses > [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) > method with scaled glyp

Re: RFR: 8265761: Font with missed font family name is not properly printed on Windows

2021-04-22 Thread Alexander Scherbatiy
On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy wrote: > PDFBox 1.8 uses > [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) > method with scaled glyp

RFR: 8265761: Font with missed font family name is not properly printed on Windows

2021-04-22 Thread Alexander Scherbatiy
PDFBox 1.8 uses [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) method with scaled glyphs to print a text and PDF 2.0 uses [Graphics2D.fill()](https://github