Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-07-19 Thread David DeHaven
After having some internal discussions we've decided to set forRemoval to false as we're not certain which release it will be removed in and it's likely to be needed in at least 10. -DrD-

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-14 Thread Kevin Rushforth
David DeHaven wrote: David had said, it seems safer to leave it false for now and revisit marking for removal in 10 I think this means, "set forRemoval=false in 9, set forRemoval=true in 10, and actually remove it in 11". I said that in reference to Applet, not JSObject.

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-14 Thread David DeHaven
> David had said, > >> it seems safer to leave it false for now and revisit marking for removal in >> 10 > > I think this means, "set forRemoval=false in 9, set forRemoval=true in 10, > and actually remove it in 11". I said that in reference to Applet, not JSObject. I now think JSObject

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-13 Thread Stuart Marks
v Cc: David Dehaven; Stuart Marks; Erik Joelsson; build-dev; build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth Subject: Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method That’s right. It requires to add a new doc bundle in the docs build. What you did was the righ

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-13 Thread Mandy Chung
t; +$(JSOBJECT_INDEX_HTML): GET2DOCSDIR=$(JSOBJECT2COREAPI)/.. >>>>>> + >>>>>> +# Run javadoc if the index file is out of date or missing >>>>>> +$(JSOBJECT_INDEX_HTML): $(JSOBJECT_OPTIONS_FILE) >>>>>> $(JSOBJECT_PACKAGES

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-13 Thread David DeHaven
tion for >>>> JSObject.getWindow(Applet) method. >>>> 2. A new doc bundle for JSObject documentation is added in the docs build. >>>> >>>> Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.01 >>>> http://cr.o

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-10 Thread Stuart Marks
t Marks; Erik Joelsson; build-dev; build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth Subject: Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method That’s right. It requires to add a new doc bundle in the docs build. What you did was the right direction. Can you update the webr

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-10 Thread Mandy Chung
-Original Message- >> From: Mandy Chung >> Sent: Wednesday, June 08, 2016 3:09 PM >> To: Daniil Titov >> Cc: David Dehaven; Stuart Marks; Erik Joelsson; build-dev; >> build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth >> Subject: Re: Review Re

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-10 Thread Daniil Titov
PM > To: Daniil Titov > Cc: David Dehaven; Stuart Marks; Erik Joelsson; build-dev; > build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth > Subject: Re: Review Request: 8156960 Deprecate > JSObject.getWindow(Applet) method > > That’s right. It requires to add a new doc bundle in the

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-10 Thread David DeHaven
/~dtitov/8156960/webrev.01 >> >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8156960 >> >> Thank you! >> >> Best regards, >> Daniil >> >> -Original Message- >> From: Mandy Chung >> Sent: Wednesday, Jun

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-10 Thread Stuart Marks
ushforth Subject: Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method That’s right. It requires to add a new doc bundle in the docs build. What you did was the right direction. Can you update the webrev? FYI. There is an effort under discussion to revisit the number of do

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-10 Thread Erik Joelsson
regards, Daniil -Original Message- From: Mandy Chung Sent: Thursday, June 09, 2016 9:23 AM To: Daniil Titov Cc: Erik Joelsson; David Dehaven; Stuart Marks; build-dev; build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth Subject: Re: Review Request: 8156960 Deprecate

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-10 Thread Alexandr Scherbatiy
: 8156960 Deprecate JSObject.getWindow(Applet) method On Jun 9, 2016, at 9:08 AM, Daniil Titov <daniil.x.ti...@oracle.com> wrote: Thank you, Erik! Please review the new version of the patch that has "../" fixed: Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-09 Thread Kevin Rushforth
, Daniil -Original Message- From: Mandy Chung Sent: Thursday, June 09, 2016 9:23 AM To: Daniil Titov Cc: Erik Joelsson; David Dehaven; Stuart Marks; build-dev; build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth Subject: Re: Review Request: 8156960 Deprecate JSObject.getWindow

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-09 Thread Daniil Titov
Chung Sent: Thursday, June 09, 2016 9:23 AM To: Daniil Titov Cc: Erik Joelsson; David Dehaven; Stuart Marks; build-dev; build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth Subject: Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method > On Jun 9, 2016, at 9:08 AM, Dan

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-09 Thread Mandy Chung
> On Jun 9, 2016, at 9:08 AM, Daniil Titov wrote: > > Thank you, Erik! > > Please review the new version of the patch that has "../" fixed: > > Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.02 >

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-09 Thread Daniil Titov
ds, Daniil -Original Message- From: Erik Joelsson Sent: Thursday, June 09, 2016 12:34 AM To: Daniil Titov; Mandy Chung Cc: David Dehaven; Stuart Marks; build-dev; build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth Subject: Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) met

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-09 Thread Erik Joelsson
- From: Mandy Chung Sent: Wednesday, June 08, 2016 3:09 PM To: Daniil Titov Cc: David Dehaven; Stuart Marks; Erik Joelsson; build-dev; build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth Subject: Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method That’s right. I

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-08 Thread Daniil Titov
arks; Erik Joelsson; build-dev; build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth Subject: Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method That’s right. It requires to add a new doc bundle in the docs build. What you did was the right direction. Can you update the we

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-08 Thread Mandy Chung
### > +# > # mgmtdocs > # > > > Best regards, > Daniil > > > > -----Original Message- > From: David DeHaven > Sent: Wednesday, June 08, 2016 1:23 PM > To: Mandy Chung > Cc: Daniil Titov; Stuart Marks; Erik Joelsson; bu

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-08 Thread Daniil Titov
2016 1:23 PM To: Mandy Chung Cc: Daniil Titov; Stuart Marks; Erik Joelsson; build-dev; build-infa-...@openjdk.java.net; awt-dev; Kevin Rushforth Subject: Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method How about NON_CORE_PKGS.gmk for javadoc? Something like: diff --git

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-08 Thread Mandy Chung
Goo.d It should have forRemoval=true in @Deprecated then. Mandy > On Jun 8, 2016, at 1:13 PM, Kevin Rushforth > wrote: > > Yes, the plan is to deprecate it in 9 and remove it in a future release. > > -- Kevin > > > Mandy Chung wrote: >> The client team owns

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-08 Thread David DeHaven
Sorry, we had LIVECONNECT_PKGS previously... -DrD- > How about NON_CORE_PKGS.gmk for javadoc? > > Something like: > > diff --git a/make/common/NON_CORE_PKGS.gmk b/make/common/NON_CORE_PKGS.gmk > --- a/make/common/NON_CORE_PKGS.gmk > +++ b/make/common/NON_CORE_PKGS.gmk > @@ -44,6 +44,8 @@ >

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-08 Thread David DeHaven
How about NON_CORE_PKGS.gmk for javadoc? Something like: diff --git a/make/common/NON_CORE_PKGS.gmk b/make/common/NON_CORE_PKGS.gmk --- a/make/common/NON_CORE_PKGS.gmk +++ b/make/common/NON_CORE_PKGS.gmk @@ -44,6 +44,8 @@ org.w3c.dom.events \ org.w3c.dom.views +JSOBJECT_PKGS =

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-08 Thread David DeHaven
Clarification: in a future *as of yet unspecified* release :) -DrD- > On Jun 8, 2016, at 1:13 PM, Kevin Rushforth > wrote: > > Yes, the plan is to deprecate it in 9 and remove it in a future release. > > -- Kevin > > > Mandy Chung wrote: >> The client team owns

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-08 Thread Kevin Rushforth
Yes, the plan is to deprecate it in 9 and remove it in a future release. -- Kevin Mandy Chung wrote: The client team owns jdk.jsobject module and so I add awt-dev to this thread. And bcc jdk9-dev. It is not Java SE API and it should not add to CORE-PKGS.gmk. As for @Deprecated, I believe

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

2016-06-08 Thread Mandy Chung
The client team owns jdk.jsobject module and so I add awt-dev to this thread. And bcc jdk9-dev. It is not Java SE API and it should not add to CORE-PKGS.gmk. As for @Deprecated, I believe the plan is to remove the getWindows method in a future release. Kevin and Dave can confirm. Mandy >