Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-02-15 Thread Prem Balakrishnan
k.java.net Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot That looks better. -phil. On 02/09/2017 10:24 PM, Prem Balakrishnan wrote: Hi Phil, Sorry, I misinterpreted the example code. Updated patch as suggested: http://cr.openjdk.java.net/~pkbala

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-02-13 Thread Phil Race
ed CCC request for the same. Regards, Prem *From:*Phil Race *Sent:* Friday, February 10, 2017 1:54 AM *To:* Prem Balakrishnan; Alexander Scherbatiy *Cc:* Sergey Bylokhov; awt-dev@openjdk.java.net *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot Your e

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-02-12 Thread Alexandr Scherbatiy
<mailto:awt-dev@openjdk.java.net> *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot Two minor grammar issues in the javadoc This method should be used in case where there is a scaling transform -> This method can be used in case

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-02-09 Thread Prem Balakrishnan
; Alexander Scherbatiy Cc: Sergey Bylokhov; awt-dev@openjdk.java.net Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot Your example here is not what I wrote :- 443 * Image nativeResImage; 444 * Image baseResImage; 445

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-02-09 Thread Phil Race
hil Race *Sent:* Thursday, February 09, 2017 1:59 AM *To:* Prem Balakrishnan; Alexander Scherbatiy *Cc:* Sergey Bylokhov; awt-dev@openjdk.java.net *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot Two minor grammar issues in the javadoc This method should b

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-02-09 Thread Prem Balakrishnan
: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot Two minor grammar issues in the javadoc This method should be used in case where there is a scaling transform -> This method can be used in case there is a scaling transform * For a high resolution display wh

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-02-08 Thread Phil Race
10:54 PM *To:* Prem Balakrishnan; Philip Race *Cc:* Sergey Bylokhov; awt-dev@openjdk.java.net *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 2/6/2017 1:19 PM, Prem Balakrishnan wrote: Hi Phil and Alex, Please review updated patch as per re

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-02-08 Thread Prem Balakrishnan
t: Tuesday, January 31, 2017 5:24 AM To: Prem Balakrishnan; Alexander Scherbatiy Cc: Sergey Bylokhov; HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot I like 3. createMultires

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-02-07 Thread Alexandr Scherbatiy
lokhov; awt-dev@openjdk.java.net *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot I like 3. createMultiresolutionScreenCapture(Rectangle rect); -phil. On 01/30/2017 01:11 AM, Prem Balakrishnan wrote: Hi Phil, Thank you for the review. >

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-02-06 Thread Prem Balakrishnan
: Tuesday, January 31, 2017 5:24 AM To: Prem Balakrishnan; Alexander Scherbatiy Cc: Sergey Bylokhov; awt-dev@openjdk.java.net Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot I like 3. createMultiresolutionScreenCapture(Rectangle rect); -phil. On 01

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-01-30 Thread Phil Race
ot is taken on non-HiDPI display Thanks, Alexandr. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Thursday, January 12, 2017 2:39 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>; Philip Race *Subject:* Re: Review Request JDK:-8

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-01-30 Thread Prem Balakrishnan
date the patch and send it for review. Regards, Prem From: Philip Race Sent: Wednesday, January 25, 2017 11:44 PM To: Alexandr Scherbatiy Cc: Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-01-25 Thread Philip Race
batiy *Sent:* Thursday, January 12, 2017 2:39 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip Race *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot > 421 * @param isHiDPI Indicates if HiDPI Display There shoul

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-01-23 Thread Alexandr Scherbatiy
Prem *From:*Alexandr Scherbatiy *Sent:* Friday, January 20, 2017 4:50 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip Race *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 1/19/2017 3:57 PM, Prem Balakrishnan wrote: H

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-01-22 Thread Prem Balakrishnan
Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 1/19/2017 3:57 PM, Prem Balakrishnan wrote: Hi Alex, Please review updated patch as per review comments. HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/8162959/webrev.06/

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-01-20 Thread Alexandr Scherbatiy
Race *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot > 421 * @param isHiDPI Indicates if HiDPI Display There should be mention that this argument value is ignored when a screenshot is taken on non-HiDPI display Please also che

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-01-19 Thread Prem Balakrishnan
K "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net; Philip Race Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot CGWindowListCreateImage() method which is used to capture a screenshot on Mac OS X by Robot has imageOption a

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-01-12 Thread Alexandr Scherbatiy
batiy *Sent:* Thursday, November 03, 2016 4:05 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net> *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 11/2/2016 1:57 PM, Prem B

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-01-10 Thread Prem Balakrishnan
: Alexandr Scherbatiy Sent: Tuesday, January 10, 2017 1:08 AM To: Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip Race Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot CGWindowListCreateImage() method which is used to capture a screenshot on

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2017-01-09 Thread Alexandr Scherbatiy
er 14, 2016 5:18 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip Race *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 07/12/16 10:24, Prem Balakrishnan wrote: Hi Alexander, Please review updated patch as per review

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2016-12-27 Thread Prem Balakrishnan
; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip Race Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 07/12/16 10:24, Prem Balakrishnan wrote: Hi Alexander, Please review updated patch as per review comments. HYPERLINK "http://cr.openjdk.jav

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2016-12-14 Thread Alexander Scherbatiy
;mailto:awt-dev@openjdk.java.net> *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 11/2/2016 1:57 PM, Prem Balakrishnan wrote: Hi Alexander, Please review updated patch. http://cr.openjdk.java.net/~pkbalakr/8162959/webrev.01/ <http://cr.openjdk.java.ne

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2016-12-06 Thread Prem Balakrishnan
Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 11/16/2016 8:46 AM, Prem Balakrishnan wrote: Hi Alexander, Please review update patch as per review comments. HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/8162959/webrev.02/

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2016-11-21 Thread Alexandr Scherbatiy
dering hints. Thanks, Alexandr. Regards, Prem *From:*Alexander Scherbatiy *Sent:* Thursday, October 13, 2016 3:21 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net> *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifac

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2016-11-15 Thread Prem Balakrishnan
: Thursday, November 03, 2016 4:05 PM To: Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 11/2/2016 1:57 PM, Prem Balakrishnan wrote: Hi Alexander, Please review updated patch. HYPERLINK

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2016-11-03 Thread Alexandr Scherbatiy
Prem *From:*Alexander Scherbatiy *Sent:* Thursday, October 13, 2016 3:21 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 06/10/16 15:28, Prem Balakrishnan wrote:

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2016-11-02 Thread Prem Balakrishnan
ith scaled width and height . Regards, Prem From: Alexander Scherbatiy Sent: Thursday, October 13, 2016 3:21 PM To: Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net Subject: Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 06/10/16 15:28, Prem Ba

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2016-10-13 Thread Alexander Scherbatiy
On 06/10/16 15:28, Prem Balakrishnan wrote: Hi*,* ** Please review fix for JDK 9, *Bug:*https://bugs.openjdk.java.net/browse/JDK-8162959 *Webrev:*http://cr.openjdk.java.net/~pkbalakr/8162959/webrev.00/ I have adapted the same fix

Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

2016-10-06 Thread Prem Balakrishnan
Hi, Please review fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-8162959 Webrev: http://cr.openjdk.java.net/~pkbalakr/8162959/webrev.00/ I have adapted the same fix as used for JavaFX Robot Bug: HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8162783"JDK-816278