Re: Review Request for 8055197: TextField deletes multiline strings

2015-11-25 Thread Sergey Bylokhov
ergey Bylokhov Sent: Monday, November 23, 2015 1:00 AM To: Alexander Scherbatiy; Ambarish Rapte Cc: awt-dev@openjdk.java.net Subject: Re: Review Request for 8055197: TextField deletes multiline strings Hello. On 06.11.15 15:05, Alexander Scherbatiy wrote: There is one thing to note that rea

Re: Review Request for 8055197: TextField deletes multiline strings

2015-11-24 Thread Ambarish Rapte
PM To: Ambarish Rapte Cc: Prasanta Sadhukhan; Semyon Sadetsky; awt-dev@openjdk.java.net Subject: Re: Review Request for 8055197: TextField deletes multiline strings The fix looks good to me. Thanks, Alexandr. On 11/19/2015 11:43 AM, Ambarish Rapte wrote: > Dear Alex, > >

Re: Review Request for 8055197: TextField deletes multiline strings

2015-11-22 Thread Ambarish Rapte
ines. >> >>Thanks, >>Alexandr. >> >>> >>> Many Thanks, >>> Ambarish >>> >>> -Original Message- >>> From: Alexander Scherbatiy >>> Sent: Thursday, October 29, 2015 9:59 PM >>> To: Ambar

Re: Review Request for 8055197: TextField deletes multiline strings

2015-11-22 Thread Sergey Bylokhov
k.java.net; Sergey Bylokhov Subject: Re: Review Request for 8055197: TextField deletes multiline strings On 10/29/2015 5:31 PM, Ambarish Rapte wrote: Hi Alexandr, Please review the updated webrev, with changes only in TextField.java. Webrev: http://cr.openjdk.java.net/~rchamyal/ambarish/8055

Re: Review Request for 8055197: TextField deletes multiline strings

2015-11-20 Thread Alexander Scherbatiy
. Many Thanks Ambarish -Original Message- From: Alexander Scherbatiy Sent: Friday, November 06, 2015 5:36 PM To: Ambarish Rapte Cc: awt-dev@openjdk.java.net Subject: Re: Review Request for 8055197: TextField deletes multiline strings On 11/5/2015 2:34 PM, Alexander Scherbatiy wrote: On 11/5

Re: Review Request for 8055197: TextField deletes multiline strings

2015-11-20 Thread Ambarish Rapte
: Prasanta Sadhukhan; Semyon Sadetsky; awt-dev@openjdk.java.net Subject: Re: Review Request for 8055197: TextField deletes multiline strings The fix looks good to me. Thanks, Alexandr. On 11/19/2015 11:43 AM, Ambarish Rapte wrote: > Dear Alex, > > Please take a look at updat

Re: Review Request for 8055197: TextField deletes multiline strings

2015-11-19 Thread Ambarish Rapte
, 2015 5:36 PM To: Ambarish Rapte Cc: awt-dev@openjdk.java.net Subject: Re: Review Request for 8055197: TextField deletes multiline strings On 11/5/2015 2:34 PM, Alexander Scherbatiy wrote: > On 11/5/2015 1:33 PM, Ambarish Rapte wrote: >> Hi Alex, >> >> I have updated th

Re: Review Request for 8055197: TextField deletes multiline strings

2015-11-06 Thread Alexander Scherbatiy
lokhov Subject: Re: Review Request for 8055197: TextField deletes multiline strings On 10/29/2015 5:31 PM, Ambarish Rapte wrote: Hi Alexandr, Please review the updated webrev, with changes only in TextField.java. Webrev: http://cr.openjdk.java.net/~rchamyal/ambarish/805

Re: Review Request for 8055197: TextField deletes multiline strings

2015-11-05 Thread Alexander Scherbatiy
ober 29, 2015 9:59 PM To: Ambarish Rapte Cc: Prasanta Sadhukhan; Semyon Sadetsky; awt-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: Review Request for 8055197: TextField deletes multiline strings On 10/29/2015 5:31 PM, Ambarish Rapte wrote: Hi Alexandr, Please review the updated we

Re: Review Request for 8055197: TextField deletes multiline strings

2015-11-05 Thread Ambarish Rapte
esday, October 28, 2015 8:48 PM > To: Ambarish Rapte > Cc: awt-dev@openjdk.java.net; Sergey Bylokhov > Subject: Re: Review Request for 8055197: TextField deletes multiline > strings > > On 10/26/2015 11:21 PM, Ambarish Rapte wrote: >> Hi Alexandr, >> Yes, This is

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-29 Thread Alexander Scherbatiy
ect: Re: Review Request for 8055197: TextField deletes multiline strings Is this is Windows specific issue only? If so, it is better to replace EOL on window text peer side or may be even better to do it on the native side before setting a text to the single-line RichEdit. May be there ar

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-29 Thread Ambarish Rapte
ly used & Also presence of '\r' in string does not result in truncation of text. Many Thanks, Ambarish -Original Message- From: Sergey Bylokhov Sent: Thursday, October 29, 2015 12:20 AM To: Ambarish Rapte; awt-dev@openjdk.java.net; Alexander Scherbatiy Subj

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-29 Thread Ambarish Rapte
nder Scherbatiy > Sent: Wednesday, October 21, 2015 7:29 PM > To: Ambarish Rapte > Cc: awt-dev@openjdk.java.net; Sergey Bylokhov > Subject: Re: Review Request for 8055197: TextField deletes multiline > strings > > > > Is this is Windows specific issue only? If so, it is

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-28 Thread Sergey Bylokhov
Hi, Ambarish. What is the reason to use this array? {System.getProperty("line.separator"), "\n"} Why we cannot use only the System.getProperty("line.separator") or which is simpler the System.lineSeparator(); On 14.10.15 19:44, Ambarish Rapte wrote: Dear All, Please review the patch for

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-28 Thread Alexander Scherbatiy
ws/desktop/bb787605(v=vs .85).aspx Many Thanks Ambarish -Original Message- From: Alexander Scherbatiy Sent: Friday, October 16, 2015 4:45 PM To: Ambarish Rapte Cc: awt-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: Review Request for 8055197: TextField deletes multiline strings The Te

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-26 Thread Ambarish Rapte
guide Thanks Ambarish -Original Message- From: Alexander Scherbatiy Sent: Wednesday, October 21, 2015 7:29 PM To: Ambarish Rapte Cc: awt-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: Review Request for 8055197: TextField deletes multiline strings Is this is Windows specific issue

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-21 Thread Alexander Scherbatiy
).aspx Many Thanks Ambarish -Original Message- From: Alexander Scherbatiy Sent: Friday, October 16, 2015 4:45 PM To: Ambarish Rapte Cc: awt-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: Review Request for 8055197: TextField deletes multiline strings The TextField is based on Rich

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-19 Thread Ambarish Rapte
: Friday, October 16, 2015 4:45 PM To: Ambarish Rapte Cc: awt-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: Review Request for 8055197: TextField deletes multiline strings The TextField is based on Rich Edit control on Windows. Does the Rich Edit control have properties to properly handle

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-16 Thread Alexander Scherbatiy
The TextField is based on Rich Edit control on Windows. Does the Rich Edit control have properties to properly handle multiline strings in single-line mode? Thanks, Alexandr. On 10/14/2015 7:44 PM, Ambarish Rapte wrote: Dear All, Please review the patch for jdk9. Bug: https

Review Request for 8055197: TextField deletes multiline strings

2015-10-14 Thread Ambarish Rapte
Dear All, Please review the patch for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8055197 Webrev: http://cr.openjdk.java.net/~rchamyal/ambarish/8055197/webrev.00/ Issue: - If text containing new line character is set to TextField, Text after new line character was termin