The fix looks good to me.
On 05/02/16 15:59, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the notes; yes, these lines are unnecessary. Please see
the updated patch:
http://cr.openjdk.java.net/~avstepan/8142861/webrev.04/
It should be also mentioned that for now the test is
Thank you!
On 2/5/2016 7:58 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
On 05/02/16 15:59, Alexander Stepanov wrote:
Hello Alexandr,
Thank you for the notes; yes, these lines are unnecessary. Please see
the updated patch:
There are just small comments about lines:
119 Graphics2D g = (Graphics2D) gr;
120 if (g != null) { g.drawImage(IMG, 0, 0, this); }
Is it necessary to cast the Graphics to Graphics2D because Graphics
also has drawImage(...) method?
Is it necessary to check the
Hello Alexandr,
Thank you for the notes; yes, these lines are unnecessary. Please see
the updated patch:
http://cr.openjdk.java.net/~avstepan/8142861/webrev.04/
It should be also mentioned that for now the test is still failing
because of JDK-8143062. Should it be added to any exclude list?
Sorry, just a reminder...
Thanks,
Alexander
On 1/14/2016 6:00 PM, Alexander Stepanov wrote:
Hello Sergey,
> Note that MultiRes image can be created at runtime
Indeed, this case should be used for testing, as we have different
naming conventions for OS X and Windows, so the write-read logic
Hello Sergey,
> Note that MultiRes image can be created at runtime
Indeed, this case should be used for testing, as we have different
naming conventions for OS X and Windows, so the write-read logic is
thrown away (as we have such tests already), and now the multiresolution
image is created
Hello Sergey,
Thank you for the notes.
> Do you have some thoughts why this test cannot be converted to auto test?
The following parts of the test scenario:
- "Please try to drag both parent and child, do it fast several times
and check if no artifacts occur." (not very valuable part of the
P.S.: The behavior with Mac OS X mission control should also be checked
which is definitely a manual job (it seems to be strange sometimes; not
sure if buggy). So the test instructions should be appended a bit...
On 11/16/2015 3:24 PM, Alexander Stepanov wrote:
Hello Sergey,
Thank you for
Hi, Alexander.
- Note that MultiRes image can be created at runtime, it will be good
to cover this also.
- Do you have some thoughts why this test cannot be converted to auto
test? Probably some api can be added to jdk to simplify creation of such
tests? like already added
webrev updated:
http://cr.openjdk.java.net/~anazarov/8142861/webrev.02/
Thanks,
Alexander
On 11/12/2015 7:51 PM, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~anazarov/8142861-3/webrev.00/
for
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~anazarov/8142861-3/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8142861
Just a single manual test added.
(sorry, I'll remove these unnecessary 'static' modifiers for
'parentName', 'childName')
Checked on
11 matches
Mail list logo
