+1
--
best regards,
Anthony
On 09/30/2013 04:08 PM, Artem Ananiev wrote:
This version of the fix looks fine.
Thanks,
Artem
On 9/27/2013 9:17 PM, Alexander Zvegintsev wrote:
Anthony,
please see inline:
On 09/27/2013 06:25 PM, Anthony Petrov wrote:
Hi Alexander,
How about
Hi Alexander,
How about getAndSetInitializationNeededFlag ?
74 * If it returns {@code false} user must call g_thread_init() on his
own.
on their own? :) Yet, it might be better phrased as:
A return value of {@code false} indicates that the calling code should
call the
Anthony,
please see inline:
On 09/27/2013 06:25 PM, Anthony Petrov wrote:
Hi Alexander,
How about getAndSetInitializationNeededFlag ?
74 * If it returns {@code false} user must call
g_thread_init() on his own.
on their own? :) Yet, it might be better phrased as:
A return value of
Hi, Alexander,
the fix looks fine in general. A few comments:
1. A few comments in gtk2_interface.c about gtk versions would be fine.
2. lock()/unlock() pattern is usually used with try - finally. Could you
modify the example in GThreadHelper, please? We don't expect C code to
use try -
Hi Alexander,
A few comments on the GThreadHelper class:
1. I think the static methods in the GThreadHelper class should be
public, because they are intended to be called by external code. Note
that all public symbols should have a javadoc.
2. Why do we need both isInitializationNeeded()
