Re: AWT Dev [8] Review request for 7068423: Spec for java.awt.GraphicsDevice.getFullScreenWindow() needs clarification

2013-10-04 Thread Anthony Petrov
Still looks fine to me, too. -- best regards, Anthony On 10/03/2013 05:17 PM, Artem Ananiev wrote: On 10/3/2013 11:30 AM, Oleg Pekhovskiy wrote: Hi All, please review the second version of fix: http://cr.openjdk.java.net/~bagiras/7068423.2/ It looks fine to me. Thanks, Artem Reason:

Re: AWT Dev [8] Review request for 7068423: Spec for java.awt.GraphicsDevice.getFullScreenWindow() needs clarification

2013-10-03 Thread Oleg Pekhovskiy
Hi All, please review the second version of fix: http://cr.openjdk.java.net/~bagiras/7068423.2/ Reason: Discussed with Artem and Andrew, came to conclusion that there were situations when returned object could be also set by the system, and not by the client application through

Re: AWT Dev [8] Review request for 7068423: Spec for java.awt.GraphicsDevice.getFullScreenWindow() needs clarification

2013-10-03 Thread Artem Ananiev
On 10/3/2013 11:30 AM, Oleg Pekhovskiy wrote: Hi All, please review the second version of fix: http://cr.openjdk.java.net/~bagiras/7068423.2/ It looks fine to me. Thanks, Artem Reason: Discussed with Artem and Andrew, came to conclusion that there were situations when returned object

Re: AWT Dev [8] Review request for 7068423: Spec for java.awt.GraphicsDevice.getFullScreenWindow() needs clarification

2013-10-01 Thread Anthony Petrov
Looks fine. -- best regards, Anthony On 10/01/2013 04:37 PM, Oleg Pekhovskiy wrote: Hi all, please review the fix http://cr.openjdk.java.net/~bagiras/7068423.1/ for https://bugs.openjdk.java.net/browse/JDK-7068423 It's just a Javadoc fix. Thanks, Oleg