Hi Petr,
I'm still a bit concerned about this line:
243 String[] values = line.substring(delimiterPosition + 1,
line.length())
244 .replace(,\\, ,)
245 .split(,);
This code now introduces another assumption, that every
Hello, AWT Team.
My apologies, but I've found a problem in the AWT part of this fix and so I
need one more review iteration.
The new version is located here:
http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.02/
The only changes comparing to the previous approved version are in
Hi Petr,
I realize that we're parsing our internal resource, however I have a few
comments regarding the reliability of the parser:
235 if (line.startsWith(#) || line.isEmpty()) continue;
Can a line start with a bunch of spaces, and then start a comment with a
'#'
On 01/07/2014 09:35, Petr Pchelko wrote:
Hello,
The changes in the public API have been approved, so let me continue
the review process.
For your convenience:
The bug: https://bugs.openjdk.java.net/browse/JDK-8047336
The fix: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/
Hello, Anthony, Alan.
Thank you for the review, the new version is located here:
http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.01/
I've changed the code to throw an InternalError if we cannot read properties.
Once I get feedback from the build team - I'll push this fix.
With best
On 02/07/2014 12:10, Petr Pchelko wrote:
Hello, Anthony, Alan.
Thank you for the review, the new version is located here:
http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.01/
http://cr.openjdk.java.net/%7Epchelko/9/8047336/webrev.00/
I've changed the code to throw an InternalError if we
Hello,
The changes in the public API have been approved, so let me continue the review
process.
For your convenience:
The bug: https://bugs.openjdk.java.net/browse/JDK-8047336
The fix: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/
Until now we've been discussing an abstract
Hi Petr,
The fix looks fine to me. Only one question:
src/share/classes/java/awt/datatransfer/SystemFlavorMap.java
234 } catch (IOException e) {
235 System.err.println(Warning reading flavor mapping: +
e.getMessage());
Is there a reason to hide the stack trace of the
On 6/20/2014 3:19 PM, Anthony Petrov wrote:
Hi Petr,
I ran the following query:
https://www.google.com/#q=custom+flavormap.properties
and the search yielded the following forum thread:
https://community.oracle.com/thread/1293314?start=0tstart=0
where developers seem to suggest they do edit
On 6/20/2014 3:29 PM, Artem Ananiev wrote:
On 6/20/2014 3:19 PM, Anthony Petrov wrote:
I ran the following query:
https://www.google.com/#q=custom+flavormap.properties
and the search yielded the following forum thread:
https://community.oracle.com/thread/1293314?start=0tstart=0
where
Hello,
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8047336
The fix is available at:
http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/
This is another step in datatransfer modularization work. This part of the work
needs a CCC, so I've moved it out to a
Hello, Alan.
Thank you for the review.
Do we know if anyone has been editing the file in ${java.home}/lib?
I couldn't find any examples on the internet although I've done a very
extensive search, so I we could add a property later if someone would request
it.
With best regards. Petr.
On 19
12 matches
Mail list logo
