Re: AWT Dev [9] Review request for 8073453: Focus doesn't move when pressing Shift + Tab keys

2015-04-13 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 4/10/2015 3:26 PM, Anton V. Tarasov wrote: Looks fine! Thanks, Anton. On 10.04.2015 10:22, dmitry markov wrote: Hi Anton, Thank you for review. Please find new version of the fix here:

Re: AWT Dev [9] Review request for 8073453: Focus doesn't move when pressing Shift + Tab keys

2015-04-09 Thread Anton V. Tarasov
Hi Dmitry, Well, the fix seems correct to me. I tried to thought of any possible regressions but nothing came to my mind (let's suppose this was really a mistake in the code). However, wouldn't you like to do the same for swing's SortingFocusTraversalPolicy? And also, include it into the

AWT Dev [9] Review request for 8073453: Focus doesn't move when pressing Shift + Tab keys

2015-04-06 Thread dmitry markov
Hello, Could you review the fix for jdk9, please? bug: https://bugs.openjdk.java.net/browse/JDK-8073453 webrev: http://cr.openjdk.java.net/~dmarkov/8073453/jdk9/webrev.00/ Problem description: The method ContainerOrderFocusTraversalPolicy.getLastComponent() always returns null if the