Hi Danesh,
Overall, the fix looks reasonable. However, I see a problem with using
the RuntimeMXBean.getName() method to obtain the information we need,
because the specification of the method states:
Returns the name representing the running Java virtual machine. The returned
name string ca
Hi Federico,
Indeed, this is a nasty issue. Thanks for spotting it. You may notice
that in most other places where something is logged, the code usually
checks whether logging is enabled for a certain level of logging, e.g.:
if (shapeLog.isLoggable(PlatformLogger.FINER)) {
2011/10/21 Anthony Petrov :
>
> Could you make a patch, test it, and post it to this mailing list for review
> please?
>
Here's a patch. I tried to follow the style used in other places where
one line if statements are used to avoid calling the logging code.
I hope the patch is acceptable.
# This
Could you please use curly braces even for one-line ifs. It looks
like it is a part of the style.
Regards, Oleg.
On Sat, Oct 22, 2011 at 6:30 AM, Federico wrote:
> 2011/10/21 Anthony Petrov :
>>
>> Could you make a patch, test it, and post it to this mailing list for review
>> please?
>>
>
> He
