Hi Anthony,
Anthony Petrov wrote:
Hi Dmitry,
The fix looks good to me. One question though:
Thanks for reviewing this!
src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java
188 while (index length) {
189 c = text.charAt(index);
190
Looks fine.
Thanks,
Artem
On 4/2/2012 7:17 PM, Sergey Bylokhov wrote:
Hi Everyone,
This testcase was targeted to the bug in metal and motif lf.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124534
Webrev can be found at: http://cr.openjdk.java.net/~serb/7124534/webrev.00/
Webrev
Looks fine.
Thanks,
Artem
On 4/2/2012 6:41 PM, Sergey Bylokhov wrote:
Hi Everyone,
See comments from the bug description:
/1. The image in Standard frame is not painted, until the frame is
[manually] resized./
Fixed: Observer was added to the drawImage().
/ 2. Test instructions should be
Looks fine.
Thanks,
Artem
On 3/29/2012 7:55 PM, Sergey Bylokhov wrote:
Hi Everyone,
On the latest version the dispose works as expected, but the test
expects that the window will be fully red. But it is not true on the mac
because of resizegrowboxwindow. Testcase updated.
Bug:
Looks fine.
Thanks,
Artem
On 3/27/2012 4:35 PM, Sergey Bylokhov wrote:
Hi Everyone,
This is a forward port from jdk 7u4:
http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/fab57f1dc2aa
The general bug is that we repaint native part of the LWPanelPeer after
UPDATE event. This is not mac
Approved.
Thanks,
Artem
On 3/26/2012 8:25 PM, Sergey Bylokhov wrote:
Hi Artem.
Done.
26.03.2012 19:26, Artem Ananiev написал:
On 3/26/2012 5:37 PM, Sergey Bylokhov wrote:
Hi, Artem.
AWT tree lock used for locking delegate.
Ah, right, I was confused by the method name,
Hi, Sergey,
the fix looks fine, however, please add more details about it to the bug
evaluation and/or suggested fix.
Thanks,
Artem
On 3/26/2012 6:24 PM, Sergey Bylokhov wrote:
Hi Everyone,
We should check container status before we set status of the component.
This check was done during
Looks fine.
Thanks,
Artem
On 3/22/2012 6:13 PM, Sergey Bylokhov wrote:
Hi Everyone,
This is a forward port from jdk 7u4:
hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/7816a64158c4
Now we reset selection in text components on focuslost event.
Bug:
After backporting from 8 the fix still looks fine :)
Thanks,
Artem
On 3/29/2012 6:30 PM, Sergey Bylokhov wrote:
Hi Everyone,
We should accept empty KeyEquivalent in case of shortcut removing.
This is a back port from jdk 8:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/74a1284ca75a
Bug:
Looks fine.
Thanks,
Artem
On 4/4/2012 7:09 PM, Anthony Petrov wrote:
Hello,
We've fixed this closed test in 7u4 by eliminating a scenario that
caused the failure. In JDK 8 we open-source the test. Please review the
fix for
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at:
Changeset: 933ea89bec06
Author:serb
Date: 2012-04-05 18:27 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/933ea89bec06
7150105: [macosx] four scroll-buttons don't display. scroll-sliders cursors are
TextCursor.
Reviewed-by: anthony, art, alexp
!
Hello,
Please review a fix for
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159266 at:
http://cr.openjdk.java.net/~anthony/7u6-4-fxHang-7159266.0/
With this fix we avoid setting an application delegate when AWT is
started in the headless mode. This prevents a hang when another GUI
Changeset: 14646df8f386
Author:serb
Date: 2012-04-05 19:01 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/14646df8f386
7124401: [macosx] After call Frame dispose() application continues to work
Reviewed-by: art, alexp
!
Hello Sergey
looks good
alexp
Hi Everyone,
A subcomponents may want to override the cursor over some of their
parts(LWTextAreaPeer changes the cursor over scrollbars).
Changes description:
1. LWComponentPeer.java:
- Just one method added getCursor();
2. LWCursorManager.java:
-
Hello Sergey
looks good
alexp
Hi Everyone,
Two issues resolved:
1) We should set caret position before the text selection.
2) On macosx we clear selection when the test component lost its
focus, so test was simplified and instructions dialog was removed
(because sometimes it steal the focus
On Apr 5, 2012, at 8:01 AM, Anthony Petrov wrote:
Hello,
Please review a fix for
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159266 at:
http://cr.openjdk.java.net/~anthony/7u6-4-fxHang-7159266.0/
With this fix we avoid setting an application delegate when AWT is started in
Hello Sergey
looks good
alexp
Hi Everyone,
This is a forward port from jdk 7u4:
http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/fab57f1dc2aa
The general bug is that we repaint native part of the LWPanelPeer
after UPDATE event. This is not mac specific bug, because we do the
same things
On 04/05/12 19:07, Mike Swingler wrote:
Please review a fix for
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159266 at:
http://cr.openjdk.java.net/~anthony/7u6-4-fxHang-7159266.0/
With this fix we avoid setting an application delegate when AWT is started in
the headless mode. This
Changeset: 004d53e61c3b
Author:serb
Date: 2012-04-05 19:43 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/004d53e61c3b
7124528: [macosx] Selection is not cleared properly in text component.
Reviewed-by: anthony, art
! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java
Changeset: dc0d4cf71dfb
Author:serb
Date: 2012-04-05 20:38 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/dc0d4cf71dfb
7125657: [macosx] SpreadSheet demo has the broken display when clicking outside
of the table.
Reviewed-by: alexp, anthony, art
!
How would an SWT developer accept new open document file double-clicks, or
listen for sleep/wake events? AFAIK, eAWT is the only aperture that handles
that right now.
Regards,
Mike Swingler
Apple Inc.
On Apr 5, 2012, at 1:11 PM, steve.x.northo...@oracle.com wrote:
Hi all,
Headless mode
21 matches
Mail list logo
