Re: AWT Dev [8] Review request for 7124376: [macosx] Modal dialog lost focus
Hi, Leonid, I wonder why you need this check for *_EXCLUDED in platform code? Whether a window should be blocked or not is determined at the shared level, in java.awt.Window/Dialog, so it's either bug in this shared code, or the check in CPlatformWindow is redundant. Thanks, Artem On 5/2/2012 11:10 PM, Leonid Romanov wrote: Hi, I've reworked my fix. See http://cr.openjdk.java.net/~leonidr/7124376/webrev.01/ On 27.04.2012, at 22:04, Anthony Petrov wrote: I've noticed that too. I didn't point this out though, because you're also checking the MODAL_EXCLUDED flag in your modallyBlocked(), so I thought it was OK. But if you can pull this check to the Java code before even calling modallyBLocked(), then I guess the setEnabled name would make more sense. -- best regards, Anthony On 4/27/2012 10:02 PM, Leonid Romanov wrote: I've looked at 7124395 and the fixes you did for FX and it looks like we need setEnabled method for AWTWindow. I'll redo my fix accordingly. On 27.04.2012, at 21:39, Anthony Petrov wrote: Hi Leonid, I was thinking of implementing a similar mechanism in order to fix 7124395. Please see the Comments section in that bug for some additional details. Regarding the fix itself: 1. Even though you return NO from canBecomeMain/KeyWindow, the OS will still bring the window to front of the z-order when you click it. In FX we handle this by always returning YES from canBecome* methods, however, the windowDidBecomeKey: sends a special FOCUS_DISABLED event if the window is blocked. In that case the upper level code re-stacks windows so that the blocker window always appears on the top of the z-order. Have you verified if this works fine for AWT apps with your fix? 2. Also, we just don't send mouse events for blocked windows from native code to Java. Is this handled somewhere else for modally blocked windows in lwawt? -- best regards, Anthony On 4/27/2012 6:11 PM, Leonid Romanov wrote: Hi, Please review a fix for 7124376: [macosx] Modal dialog lost focus. One can easily reproduce this bug by launching SwingSet2, choosing JOptionPane demo and then clicking Show Message Dialog button. Now, click on the SwingSet2 window title bar and you'll see the window rapidly gaining and loosing focus. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124376 webrev: http://cr.openjdk.java.net/~leonidr/7124376/webrev.00/ Thanks, Leonid.
Re: AWT Dev [8] Review request for 7166437: [macosx] Support for Window.Type.UTILITY on the Mac
Hi, Anthony, the fix looks fine. Thanks, Artem On 5/4/2012 4:15 PM, Anthony Petrov wrote: Hello, Please review this rather trivial fix for http://bugs.sun.com/view_bug.do?bug_id=7166437 at: http://cr.openjdk.java.net/~anthony/8-31-UTILITY-7166437.0/ -- best regards, Anthony
Re: AWT Dev [7u6] Review request for 7144542: [macosx] Crash in liblwawt.dylib setBusy() when exiting an FX app run with j2d pipeline
On 5/4/2012 6:53 PM, Anthony Petrov wrote: Hello, Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7144542 at: http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.0/ So what you do is to change headful CToolkit to headless XToolkit, correct? Note that this change will also trigger Java2D pipeline change, which might not be what we want. Have you tried to find out what exactly leads to the crash when CToolkit is used? Thanks, Artem Note: in JDK 8 we already load the headless version of the AWT library, and this prevents the crash. Now I'm applying the same logic to JDK 7u6. -- best regards, Anthony
Re: AWT Dev hg: jdk8/awt/jdk: 7024963: Notepad demo: remove non-translatable resources from Notepad.properties file
Hi, Alexandr.
In this fix fileDialog variable was deleted from the Notepad.java. But
it is used in Stylepad demo. So now full jdk build failed with error:
C:\moe\workspaces\jdk\8\awt-mix\build\windows-i586\democlasses\demo\jfc\Stylepad\src\Stylepad.java:249:
error: cannot find symbol
if (fileDialog == null) {
^
symbol: variable fileDialog
location: class Stylepad.OpenAction
04.05.2012 13:16, alexandr.scherba...@oracle.com wrote:
Changeset: a714e2e2b257
Author:alexsch
Date: 2012-05-04 13:15 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a714e2e2b257
7024963: Notepad demo: remove non-translatable resources from
Notepad.properties file
Reviewed-by: rupashka
! src/share/demo/jfc/Notepad/Notepad.java
! src/share/demo/jfc/Notepad/resources/Notepad.properties
+ src/share/demo/jfc/Notepad/resources/system.properties
AWT Dev hg: jdk8/awt/jdk: 7080109: Dialog.show() lacks doPrivileged() to access system event queue
Changeset: 912e666b4e1d Author:serb Date: 2012-05-10 20:05 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/912e666b4e1d 7080109: Dialog.show() lacks doPrivileged() to access system event queue Reviewed-by: art, anthony ! src/share/classes/java/awt/Dialog.java + test/java/awt/Dialog/ModalDialogPermission/ModalDialogPermission.java + test/java/awt/Dialog/ModalDialogPermission/java.policy
AWT Dev hg: jdk8/awt: 6 new changesets
Changeset: 47aa0ddc9126 Author:katleman Date: 2012-04-26 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/47aa0ddc9126 Added tag jdk8-b36 for changeset 6a6ba0a07f33 ! .hgtags Changeset: afeeed8e5f8c Author:ihse Date: 2012-04-30 12:13 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/afeeed8e5f8c 7165277: Fix missing execute permission issue running logger.sh Reviewed-by: ohair ! common/autoconf/configure ! common/autoconf/configure.ac Changeset: b2972095a4b1 Author:katleman Date: 2012-05-02 15:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/b2972095a4b1 Merge Changeset: 2eeb9fac7dfc Author:katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/2eeb9fac7dfc Added tag jdk8-b37 for changeset b2972095a4b1 ! .hgtags Changeset: 2f06b15e2439 Author:ewendeli Date: 2012-05-03 14:17 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/rev/2f06b15e2439 7154130: Add Mac OS X Instructions to README-builds.html Reviewed-by: ohair Contributed-by: edvard.wende...@oracle.com ! README-builds.html Changeset: d939bd0ab13c Author:katleman Date: 2012-05-09 16:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/d939bd0ab13c Merge
AWT Dev hg: jdk8/awt/corba: 7 new changesets
Changeset: 83fac66442cf Author:katleman Date: 2012-04-26 14:05 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/83fac66442cf Added tag jdk8-b36 for changeset a5a61f259961 ! .hgtags Changeset: c6c0b1047985 Author:jmelvin Date: 2012-04-16 17:10 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/c6c0b1047985 7130404: [macosx] os.arch value should be x86_64 for compatibility with Apple JDK6 Summary: On Mac OS X, align system property os.arch with Apple legacy JDKs. Also, improve os.name string matching by using .contains() method instead of .startsWith(). This fix spans multiple repositories. Reviewed-by: dcubed, phh, ohair, katleman ! make/common/shared/Platform.gmk Changeset: 9cdcc0152526 Author:coffeys Date: 2012-04-20 17:34 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/9cdcc0152526 7161925: sjava files in corba don't have copyright string and legal notice Reviewed-by: chegar Contributed-by: misha.by...@oracle.com ! src/share/classes/com/sun/corba/se/impl/orbutil/DefineWrapper.sjava ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLTypesUtil_save.sjava Changeset: df0c7369a86b Author:lana Date: 2012-04-26 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/df0c7369a86b Merge Changeset: 4a653e435441 Author:lana Date: 2012-05-01 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/4a653e435441 Merge Changeset: 2d2f6b0f855b Author:katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/2d2f6b0f855b Added tag jdk8-b37 for changeset 83fac66442cf ! .hgtags Changeset: b8cbfb31139f Author:katleman Date: 2012-05-09 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/b8cbfb31139f Merge
AWT Dev hg: jdk8/awt/jaxws: 2 new changesets
Changeset: b05a948db1b6 Author:katleman Date: 2012-04-26 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/b05a948db1b6 Added tag jdk8-b36 for changeset 89b36c658e39 ! .hgtags Changeset: ac1ba3b56775 Author:katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/ac1ba3b56775 Added tag jdk8-b37 for changeset b05a948db1b6 ! .hgtags
AWT Dev hg: jdk8/awt/hotspot: 21 new changesets
Changeset: bfcf92bfefb8 Author:katleman Date: 2012-04-26 14:05 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bfcf92bfefb8 Added tag jdk8-b36 for changeset 50b4400ca1ec ! .hgtags Changeset: 4ee58fcab520 Author:katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4ee58fcab520 Added tag jdk8-b37 for changeset bfcf92bfefb8 ! .hgtags Changeset: 3c91f2c9fd21 Author:amurillo Date: 2012-04-20 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3c91f2c9fd21 7163193: new hotspot build - hs24-b09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f3a4ee95783b Author:kevinw Date: 2012-04-20 14:55 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f3a4ee95783b 7162488: VM not printing unknown -XX options Reviewed-by: dholmes, kamg ! src/share/vm/runtime/arguments.cpp + test/runtime/7162488/Test7162488.sh Changeset: 29ee40a082d3 Author:sla Date: 2012-04-23 13:30 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/29ee40a082d3 7162063: libsaproc debug print should format size_t correctly on 64bit platform Reviewed-by: rbackman, mgronlun, dholmes ! agent/src/os/linux/ps_core.c Changeset: f33c4d0f4c9e Author:dcubed Date: 2012-04-23 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f33c4d0f4c9e Merge Changeset: d652a62d6e03 Author:dcubed Date: 2012-03-23 11:50 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d652a62d6e03 7102323: RFE: enable Full Debug Symbols Phase 1 on Solaris Summary: Add support for ENABLE_FULL_DEBUG_SYMBOLS and ZIP_DEBUGINFO_FILES build flags. Add support for .diz files. Reviewed-by: dholmes, ohair, sspitsyn ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make ! make/windows/makefiles/sa.make Changeset: 744728c16316 Author:dcubed Date: 2012-04-03 09:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/744728c16316 7158067: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect product builds Summary: Build option FULL_DEBUG_SYMBOLS=0 only affects product builds. Reviewed-by: ohair, jmelvin, sspitsyn ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/defs.make ! make/solaris/Makefile ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 74c359c4a9e5 Author:dcubed Date: 2012-04-24 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/74c359c4a9e5 Merge ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make Changeset: d6c393b0164b Author:dcubed Date: 2012-04-25 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d6c393b0164b 7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows Summary: Disable FDS by default on Solaris; disable ZIP_DEBUGINFO_FILES by default on Windows. Reviewed-by: acorn, sspitsyn ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 973046802b6f Author:dlong Date: 2012-04-26 16:24 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/973046802b6f 7162955: Attach api on Solaris, too many open files Summary: Release server-side socket after client receives it. Reviewed-by: sla, dsamersoff, dcubed, acorn Contributed-by: dean.l...@oracle.com ! src/os/solaris/vm/attachListener_solaris.cpp Changeset: 6f0612ea55ce Author:jprovino Date: 2012-05-02 15:47 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6f0612ea55ce Merge Changeset: 9f059abe8cf2 Author:jmasa Date: 2012-03-29 19:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9f059abe8cf2 7131629: Generalize the CMS free list code Summary: Make the FreeChunk, FreeList, TreeList, and BinaryTreeDictionary
