Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

On 3/17/2015 8:15 PM, Phil Race wrote: Hi, this looks fine but could you confirm this was tested on a system that exhibited the problem and also add a note of evaluation in the bug perhaps pasting in the error message from the earlier bug as it helps to explain the fix Yes, the fix is tes

Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8075244/webrev.01 - The check for SWT running is added to the SplashGetScaledImageName() method. On 3/17/2015 8:54 PM, Sergey Bylokhov wrote: Hi, Alexander. Can you check another call to sharedApplication in th

Re: [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

Hi Sergey, The only dependency on JFX/interop is this method in DropTargetContext.java: 98 public void addNotify(final Object dtcp) throws IllegalArgumentException { Was that the reason why you left the parameter? Is it technically possible to retrieve the peer via the ComponentAccessor.ge

Re: [9] Review request for 8075244 [macosx] The fix for JDK-8043869 should be reworked

18.03.15 7:53, Alexander Scherbatiy wrote: It is possible just call [NSApplicationAWT sharedApplication] on the main thread because SplashGetScaledImageName() method creates its own NSAutoreleasePool and does not need to restart the app. Will our splash screen work in case of JAVA_STARTED_

Re: [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

Hi, Anton. The problem is that this method is called when the peer itself change the information in the DropTargetContext. So this method works like a setter. I can make this method private, and get an access to it via accessor. Will it be better? 18.03.15 8:27, Anton V. Tarasov wrote: Hi Se

Re: [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

Hi, Anton. The problem is that this method is called when the peer itself change the information in the DropTargetContext. So this method works like a setter. I can make this method private, and get an access to it via accessor. Will it be better? 18.03.15 8:27, Anton V. Tarasov wrote: Hi Se

[9] Review request for 8074481: [macosx] Menu items are appearing on top of other windows

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8074481/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8074481 Problem: applet popup windows are not closed when other n

Re: [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

I think its preferable to remove (hide) the method rather than leave one that no application code can (or should) call because they can't provide a parameter of the required type. -phil. On 03/18/2015 09:24 AM, Sergey Bylokhov wrote: Hi, Anton. The problem is that this method is called when

Re: [9] Review Request: 8074763 Remove API references to java.awt.dnd.peer

My first assumption was that we can get rid of the peer parameter at all (like you did in DropTarget.java), however this doesn't seem possible regardless of JFX/interop (AFAICS). On 18/03/15 19:23, Sergey Bylokhov wrote: Hi, Anton. The problem is that this method is called when the peer itself