Re: Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the end

2016-01-14 Thread Ambarish Rapte
Hi Prasanta, Yes, verified in windows. The fix for windows only. But the test will be executed for all platforms. Selected text varies platform to platform as double clicking on word might select the word with or without suffixing space character.

Re: Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the end

2016-01-14 Thread prasanta sadhukhan
Hi Ambarish, This if (textArea.getSelectedText().contentEquals("")) { dispose(); throw new RuntimeException ("The robot test operations did not " + "sync properly."); } robot not synchronizing is not actually testing the bug. Probably you can com

Re: Review request for 7087869: [TEST_BUG] [macosx] No mac os x support in test java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.

2016-01-14 Thread Sergey Bylokhov
+1 On 14/01/16 08:37, Ambarish Rapte wrote: Hi, This fix looks good to me. Modified test passes on ubuntu and windows also. Thanks Ambarish *From:*Manajit Halder *Sent:* Wednesday, January 13, 2016 6:38 PM *To:* Ambarish Rajeshwar Rapte; Semyon Sadetsky; awt

Re: Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the end

2016-01-14 Thread Ambarish Rapte
Hi Prasanta, Thanks for the review, Updated the webrev as per the suggested comments, http://cr.openjdk.java.net/~arapte/6180449/webrev.02/ Please take a look. Thanks, Ambarish From: prasanta sadhukhan Sent: Thursday, January 14, 20

Re: Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the end

2016-01-14 Thread prasanta sadhukhan
Looks ok to me. Regards Prasanta On 1/14/2016 5:38 PM, Ambarish Rapte wrote: Hi Prasanta, Thanks for the review, Updated the webrev as per the suggested comments, http://cr.openjdk.java.net/~arapte/6180449/webrev.02/ Please take a

Re: P.S.: Re: Review Request for 8142861: [TEST_BUG] MultiResolution image: add a manual test for two-display configuration (HiDPI + non-HiDPI)

2016-01-14 Thread Alexander Stepanov
Hello Sergey, > Note that MultiRes image can be created at runtime Indeed, this case should be used for testing, as we have different naming conventions for OS X and Windows, so the write-read logic is thrown away (as we have such tests already), and now the multiresolution image is created at

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-14 Thread Magnus Ihse Bursie
On 2015-12-18 15:11, Wang Weijun wrote: Hi Vinnie I take a look and it includes a change for src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp in the Java_sun_security_mscapi_KeyStore_getKeyLength() function. It seems there is no sun.security.mscapi.KeyStore#getKeyLength on the j

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-14 Thread Magnus Ihse Bursie
On 2016-01-05 03:25, Kim Barrett wrote: On Dec 18, 2015, at 7:41 PM, Kim Barrett wrote: On Dec 16, 2015, at 8:50 AM, Magnus Ihse Bursie wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8145549 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8145549-vs2015-community-edition/webrev.01 /Magn

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-14 Thread Wang Weijun
> On Jan 14, 2016, at 11:00 PM, Magnus Ihse Bursie > wrote: > > On 2015-12-18 15:11, Wang Weijun wrote: >> Hi Vinnie >> >> I take a look and it includes a change for >> src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp in the >> Java_sun_security_mscapi_KeyStore_getKeyLength() f