Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L&F on Win 8.1 with HiDPI display

2016-03-15 Thread Sergey Bylokhov
On 11.03.16 21:54, Alexandr Scherbatiy wrote: I need one more reviewer for the fix. Looks fine. On 2/15/2016 11:24 AM, Jim Graham wrote: Thanks Alexandr, The AWT changes all look good. I'll leave it to others as to whether the test case represents the best way to test this. I have no i

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

2016-03-15 Thread Rajeev Chamyal
Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145173/webrev.04/ Alexandr : I have build code with VS2013 and I didn't get any errors you mentioned. Still I have updated the code as suggested. Added build team for make file review. JPRT build with fix was su

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

2016-03-15 Thread Alexander Scherbatiy
On 15/03/16 16:56, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145173/webrev.04/ Alexandr : I have build code with VS2013 and I didn't get any errors you mentioned. Still I have updated the code as suggested. I would suggest to b

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

2016-03-15 Thread Erik Joelsson
Build changes look ok. /Erik On 2016-03-15 15:08, Alexander Scherbatiy wrote: On 15/03/16 16:56, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145173/webrev.04/ Alexandr : I have build code with VS2013 and I didn't get any errors yo

About JDK-8137571

2016-03-15 Thread Mario Torre
Hi all, I'm interested in backporting this change to 8u: https://bugs.openjdk.java.net/browse/JDK-8137571 Before I go on and rework/test the patch on 8 I would like to know if this is desired (or if you are already planning to do that!). Cheers, Mario

Re: [9] Review request for 8149849 [hidpi] DnD issues (cannot DnD from JFileChooser to JEditorPane or other text component) when scale > 1

2016-03-15 Thread Alexandr Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8149849/webrev.02/ The test is renamed to DNDTextToScaledArea. Thanks, Alexandr. On 3/11/2016 12:08 PM, Phil Race wrote: As well as Swing I think the sustaining org also used to do this once upon a time but I persona

Re: [9] Review request for 8149849 [hidpi] DnD issues (cannot DnD from JFileChooser to JEditorPane or other text component) when scale > 1

2016-03-15 Thread Sergey Bylokhov
On 15.03.16 18:24, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8149849/webrev.02/ The test is renamed to DNDTextToScaledArea. looks fine, thanks. Thanks, Alexandr. On 3/11/2016 12:08 PM, Phil Race wrote: As well as Swing I

Re: [9] Review request for 8149849 [hidpi] DnD issues (cannot DnD from JFileChooser to JEditorPane or other text component) when scale > 1

2016-03-15 Thread Phil Race
+1 -phil. On 03/15/2016 08:31 AM, Sergey Bylokhov wrote: On 15.03.16 18:24, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8149849/webrev.02/ The test is renamed to DNDTextToScaledArea. looks fine, thanks. Thanks, Alexandr.

Re:

2016-03-15 Thread Alexandr Scherbatiy
The JDK fixes should be pushed to the JDK 9 first and then be back-ported to JDK 8. Could you prepare the fix for JDK 9? Thanks, Alexandr. On 3/12/2016 3:23 AM, Hendrik Schreiber wrote: Thanks, Alexander. Can you also review it? -hendrik On Mar 11, 2016, at 19:06, Alexander Scherba