Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

2016-04-19 Thread Manajit Halder
Hi Prasanta, Thank you for the review comments. Please review the updated webrev. http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/ Regards, Manajit > On 18-Apr-2016, at 3:30 pm, prasanta sadhukhan > wrote: > > Hi Manajit. > > W

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

2016-04-19 Thread prasanta sadhukhan
Looks ok to me. Regards Prasanta On 4/19/2016 1:25 PM, Manajit Halder wrote: Hi Prasanta, Thank you for the review comments. Please review the updated webrev. http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/ Regards, Manajit

[9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

2016-04-19 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154434 webrev: http://cr.openjdk.java.net/~ssadetsky/8154434/webrev.00/ To support the new FocusEvent cause concept introduced by JDK-8080395 the next package-private methods of the java.awt.Component class are

Re:

2016-04-19 Thread Hendrik Schreiber
> On Mar 22, 2016, at 17:43, Hendrik Schreiber wrote: > >> >> I created an application in Visual Studio and try to check the returned icon >> size. >> It returns the same size 16 for both IDB_VIEW_SMALL_COLOR and >> IDB_VIEW_LARGE_COLOR. > > Really? That would contradict the documentation. U

Re: [9] Review request for 8132706 [macosx] Toolkit.getImage() throws NPE for null URL

2016-04-19 Thread Sergey Bylokhov
On 18.04.16 21:25, Alexander Scherbatiy wrote: The spec of checkImage/prepareImage both return incorrect status in case of null, seems both should throw NPE also. otherwise they report null as a valid fully loaded image. The question under discussion is not about null images but about a Too

Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

2016-04-19 Thread Sergey Bylokhov
On 22.03.16 23:05, Phil Race wrote: I think a subset of the words I used :- * Returns whether dynamic layout of Containers on resize is currently * enabled on the underlying operating system and/or window manager) * and which will be followed by the JDK in determining layout

Re: [9] Review Request: 8027324 The spec for Toolkit.setDynamicLayout() and Toolkit.isDynamicLayoutActive() needs to be clarified

2016-04-19 Thread Philip Race
Gosh, I had completely paged that one out. I think this is fine as best as I remember the nuances. -phil. On 4/19/16, 7:21 AM, Sergey Bylokhov wrote: On 22.03.16 23:05, Phil Race wrote: I think a subset of the words I used :- * Returns whether dynamic layout of Containers on resize is