Re: [9] Review request 8155083: On Windows, usage of USER_ATTENTION_WINDOW depends on state setting order

2016-09-01 Thread Semyon Sadetsky
Hi Alexander, FlashWindow() flashes window only once. Before the fix it was 3 times. Will it be ok for the iconified window state? --Semyon On 26.08.2016 05:53, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8155083/00/ for the issue

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

2016-09-01 Thread Rajeev Chamyal
Hello Kumar, Can you please review the updated src/java.base/share/classes/sun/launcher/resources/launcher.properties http://cr.openjdk.java.net/~rchamyal/8151787/webrev.06/ Regards, Rajeev Chamyal -Original Message- From: Philip Race Sent: 27 August 2016 03:10 To: Rajeev Chamyal Cc:

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

2016-09-01 Thread Anton Tarasov
On 31 Aug 2016, at 21:04, Sergey Bylokhov wrote: > > On 30.08.16 18:18, Anton Tarasov wrote: As I wrote in JIRA, the problem is caused by the fact that a native window (for a modal dialog) is shown before the peer starts to show. (This seems strange, and you can investigate the rea

Re: [9] Review request 8155083: On Windows, usage of USER_ATTENTION_WINDOW depends on state setting order

2016-09-01 Thread Alexander Zvegintsev
Hi Semyon, This is intended. Sure, it will(the issue is filed against this test case, so it is the first test case I've checked). On 9/1/16 10:45 AM, Semyon Sadetsky wrote: Hi Alexander, FlashWindow() flashes window only once. Before the fix it was 3 times. Will it be ok for the iconified

Re: [9] Review request 8155083: On Windows, usage of USER_ATTENTION_WINDOW depends on state setting order

2016-09-01 Thread Semyon Sadetsky
I thought that the native Windows behavior is flashing it several times. But probably it is not true. Then the fix looks good. --Semyon On 01.09.2016 14:26, Alexander Zvegintsev wrote: Hi Semyon, This is intended. Sure, it will(the issue is filed against this test case, so it is the first

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

2016-09-01 Thread Sergey Bylokhov
On 01.09.16 12:51, Anton Tarasov wrote: On 31 Aug 2016, at 21:04, Sergey Bylokhov wrote: On 30.08.16 18:18, Anton Tarasov wrote: As I wrote in JIRA, the problem is caused by the fact that a native window (for a modal dialog) is shown before the peer starts to show. (This seems strange, and yo

Re: [9] Review request for 8163101: dual-screen issue with JMenu, JPopupMenu

2016-09-01 Thread Semyon Sadetsky
On 31.08.2016 21:18, Sergey Bylokhov wrote: On 31.08.16 17:18, Semyon Sadetsky wrote: Toolkit.getDefaultToolkit().getScreenSize() was replaced by graphicsConfig.getBounds(); that returns a particular screen area which is not the same as the joint screen area in case of Xinerama multi-monito

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

2016-09-01 Thread Kumar Srinivasan
Hello Rajeev, IMHO, this really belongs here: http://hg.openjdk.java.net/jdk9/dev/jdk/file/1c28399f1b50/src/java.desktop/share/classes/java/awt/SplashScreen.java and here: https://docs.oracle.com/javase/8/docs/technotes/tools/unix/java.html If you can reduce the words in the launcher, it wou

Re: Review request for 8160570: [mac] modal dialog can skip the activation/focus events

2016-09-01 Thread Anton Tarasov
On 01 Sep 2016, at 14:31, Sergey Bylokhov wrote: > > On 01.09.16 12:51, Anton Tarasov wrote: >> On 31 Aug 2016, at 21:04, Sergey Bylokhov wrote: >>> >>> On 30.08.16 18:18, Anton Tarasov wrote: >> As I wrote in JIRA, the problem is caused by the fact that a native >> window (for a modal

Re: [9] Review request for 8050478: [macosx] Cursor not updating correctly after closing a modal dialog

2016-09-01 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/30/2016 11:20 AM, Dmitry Markov wrote: Thank you very much, Sergey! Looking for a second +1 from someone else. Thanks, Dmitry On 29 Aug 2016, at 18:53, Sergey Bylokhov wrote: Looks fine. On 25.08.16 13:53, Dmitry Markov wrote: Hi Sergey,

Re: [9] Review request for 8163100: [hidpi] Linux: display-wise scaling factor issues

2016-09-01 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/31/2016 2:07 PM, Sergey Bylokhov wrote: Looks fine. On 31.08.16 11:11, Semyon Sadetsky wrote: On 8/30/2016 11:57 PM, Sergey Bylokhov wrote: Why in X11GraphicsDevice.java we cannot call initScaleFactor() directly without isUIScaleEnabled() che

RFR: XXS: (doc) Toolkit.isDynamicLayoutActive(): orphan '0' in first sentence

2016-09-01 Thread Iris Clark
Hi. Please review the following one character change to remove an unnecessary ')' in the first sentence of Toolkit.isDynamicLayoutActive(). The matching '(' was removed during resolution of JDK-8027234 (build 120) which clarified the specification of this method. 8165269: (doc) Toolkit.isDyn

Re: RFR: XXS: (doc) Toolkit.isDynamicLayoutActive(): orphan '0' in first sentence

2016-09-01 Thread Iris Clark
Problematic cut-and-paste coupled with misbehaving mail client. Let me generate the webrev to be crystal clear. Thanks, iris -Original Message- From: Iris Clark Sent: Thursday, September 01, 2016 1:32 PM To: aw >> OpenJDK awt-dev Cc: Iris Clark Subject: RFR: XXS: (doc) Toolkit.isDynamic

RFR (XXS) 8165269: (doc) Toolkit.isDynamicLayoutActive(): orphan '0' in first sentence

2016-09-01 Thread Iris Clark
Hi. Let's try this again. Please review the following one character change to remove an unnecessary ')' in the first sentence of Toolkit.isDynamicLayoutActive(). The matching '(' was removed during resolution of JDK-8027234 (build 120) which clarified the specification of this method. Bug: