Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

2016-09-12 Thread Rajeev Chamyal
Hello Kumar, Thanks for the review. Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8151787/webrev.09/ Updates: 1) Updated launcher properties. 2) Corrected indentation in splashscreen_impl.c Regards, Rajeev Chamyal -Original Message- From: Kumar Srinivasan Sent

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

2016-09-12 Thread Kumar Srinivasan
-\ HiDPI and Non-HiDPI.Scaled filename convention should be\n\ +\ HiDPI and Non-HiDPI. Scaled filename convention should be\n\ +\ used for HiDPI images\n\ Space after . Approved, contingent on the above fix, I don't need to see another iteration

RFR: JDK-8165798 Fix license and copyright headers under test/java/awt

2016-09-12 Thread Ken Chen
** *Hello,* * Please review the patch below which fixes copyright in test files for awt Bug:https://bugs.openjdk.java.net/browse/JDK-8165798 Webrev: http://cr.openjdk.java.net/~shurailine/8165798/webrev.00/

Re: RFR: JDK-8165798 Fix license and copyright headers under test/java/awt

2016-09-12 Thread Iris Clark
Hi, Ken.   These changes appear to be the expected modifications.   The only potential problem I see is in test/java/awt/dnd/DnDFileGroupDescriptor/DnDfileGroupDescriptor.java [0] where it appears that an extra space has been inserted at line 24 immediately before the beginning of comment (c