Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

2016-10-07 Thread Semyon Sadetsky
Hi Sergey, After applying the patch I found 72 usages of the Event class. Why they are not replaced? --Semyon On 10/2/2016 4:53 PM, Sergey Bylokhov wrote: Thanks for the comments. The new version: http://cr.openjdk.java.net/~serb/8143077/webrev.01 The specification of Event class and InputE

Re: [9] Review Request: 8166673 The new implementation of Robot.waitForIdle() may hang

2016-10-07 Thread Semyon Sadetsky
Hi Sergey, 1525 queueEmpty = false; 1526 eventDispatched = false; 1527 synchronized(waitLock) { Shouldn't lines 1525 & 1526 be moved inside the synchronized block? --Semyon On 9/26/2016 8:38 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The SunTo

[9] Review request for JDK-8158380: Regression: java/awt/List/ActionEventTest/ActionEventTest.java

2016-10-07 Thread Manajit Halder
Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8158380 Webrev: http://cr.openjdk.java.net/~mhalder/8158380/webrev.00/ Issue: Regression: java/a

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

2016-10-07 Thread Sergey Bylokhov
On 07.10.16 10:06, Semyon Sadetsky wrote: Hi Sergey, After applying the patch I found 72 usages of the Event class. Why they are not replaced? By the same reason why InputEvent.getModifiers() was not replaced by InputEvent.getModifiersEx(): >>> We can replace old constants by the new on

Re: [9] Review Request: 8166673 The new implementation of Robot.waitForIdle() may hang

2016-10-07 Thread Sergey Bylokhov
On 07.10.16 10:28, Semyon Sadetsky wrote: Hi Sergey, 1525 queueEmpty = false; 1526 eventDispatched = false; 1527 synchronized(waitLock) { Shouldn't lines 1525 & 1526 be moved inside the synchronized block? I think so, at least this will unify how we use these in dispat

Re: [9] Review request for JDK-8158380: Regression: java/awt/List/ActionEventTest/ActionEventTest.java

2016-10-07 Thread Sergey Bylokhov
Hi, Manajit. Instead of adding these methods between operations you can call these after robot creation: Robot.setAutoDelay(int ms) Robot.setAutoWaitForIdle(boolean isOn) On 07.10.16 15:10, Manajit Halder wrote: Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.n

[9] Review request for JDK-8161473:[TEST_BUG] [macosx] add autodelay to java/awt/TrayIcon/TrayIconEventModifiers/TrayIconEventModifiersTest.java

2016-10-07 Thread Anubhav Meena
Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8161473 Webrev: http://cr.openjdk.java.net/~rchamyal/anmeena/8161473/webrev.00/ Issue: [macosx] The test java/awt/TrayIcon/TrayIconEventModifiers/TrayIconEventModifiersTest.java often fails, especially on

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-10-07 Thread Alan Burlison
On 06/10/2016 22:26, Alan Burlison wrote: Oh .. Alan see you already did exactly that :-). So we are in agreement there. Yes, seen the push - thanks :-) I'll check with a fresh clone tomorrow but I *think* with this committed Java9 now builds cleanly on Solaris 12. Yay! :-) Hmm, I've just p

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-10-07 Thread Philip Race
You are looking at the wrong forest. All client changes must always go to http://hg.openjdk.java.net/jdk9/client. -phil. On 10/7/16, 11:35 AM, Alan Burlison wrote: On 06/10/2016 22:26, Alan Burlison wrote: Oh .. Alan see you already did exactly that :-). So we are in agreement there. Yes, s

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-10-07 Thread Alan Burlison
On 07/10/16 19:40, Philip Race wrote: You are looking at the wrong forest. All client changes must always go to http://hg.openjdk.java.net/jdk9/client. Ah, right. Will that end up in dev eventually? I haven't found anything so far that explains the relationships between all the repo forests..

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

2016-10-07 Thread Philip Race
jdk9/jdk9 is the master from which RE builds are created jdk9/dev is for core-libs + tools + similar jdk9/client is for client jdk9/hs-=* are the various hotspot ones .. Generally you can think of "dev" as the only direct child of master. jdk9/hs and jdk9/client are children of dev the hs-* ones