Re: [10] RFR JDK-8190456: sanity/client/SwingSet/src/ComboBoxDemoTest.java failed with NPE from java.awt.EventQueue.getCurrentEventImpl()

2017-11-02 Thread Muneer Kolarkunnu
Hi Sergey, These are jtreg test cases only, you can run using jtreg command. But right now there is a compilation issue, one import statement is missing in jemmy file FrameOperator.java(import org.netbeans.jemmy.JemmyException;). It introduced by one of the recent task JDK-8188779. It already re

Re: [10] RFR JDK-8190456: sanity/client/SwingSet/src/ComboBoxDemoTest.java failed with NPE from java.awt.EventQueue.getCurrentEventImpl()

2017-11-02 Thread Sergey Bylokhov
Looks fine. On 01/11/2017 01:33, Muneer Kolarkunnu wrote: Hi All, Please review fix for the below bug: Bug: https://bugs.openjdk.java.net/browse/JDK-8190456 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8190456/webrev.00/ This issue observed during SBR(Same Binary Run) execution of client

Re: [10] RFR JDK-8190456: sanity/client/SwingSet/src/ComboBoxDemoTest.java failed with NPE from java.awt.EventQueue.getCurrentEventImpl()

2017-11-02 Thread Sergey Bylokhov
Can you please take a look to this test as well: https://bugs.openjdk.java.net/browse/JDK-8157338 Looks like this is the last unstable test in sanity/client testsuite. On 02/11/2017 04:41, Muneer Kolarkunnu wrote: Hi Sergey, These are jtreg test cases only, you can run using jtreg command. But

Re: [10] Review request for 8189201: [macosx] NotSerializableException during JFrame with MenuBar serialization

2017-11-02 Thread Sergey Bylokhov
Some small question while I do a review of other parts. After the fix the classes which store the listeners like AccessibleAWTFocusHandler supports serialisation, but most of them are used in pair with propertyListenersCount which is transient. Should we serialize the count of listeners? But fr

Re: [10] Review Request: 8186617 The "com.sun.awt.AWTUtilities" class can be dropped in favour of public API

2017-11-02 Thread Sergey Bylokhov
On 30/10/2017 08:17, Semyon Sadetsky wrote: On 10/26/2017 10:51 PM, Sergey Bylokhov wrote: This is not a last patch, since it was not a request for review. v01 is a change in AWTUtilities only, which will not be removed as it was proposed and reviewed in v00. Then please provide the final webr

Re: [10] RFR JDK-8190456: sanity/client/SwingSet/src/ComboBoxDemoTest.java failed with NPE from java.awt.EventQueue.getCurrentEventImpl()

2017-11-02 Thread Prasanta Sadhukhan
Hi Muneer, Earlier, before your fix, if Thread.currentThread() is not equal to  dispatchThread, then it was returning " null", but now it will not return anything even though return value should be AWTEvent. Is it not giving any compilation problem? Regards Prasanta On 11/1/2017 2:03 PM, Mune