Re: [10] RFR JDK-8190456: sanity/client/SwingSet/src/ComboBoxDemoTest.java failed with NPE from java.awt.EventQueue.getCurrentEventImpl()

2017-11-08 Thread Sergey Bylokhov
+1 On 07/11/2017 23:52, Prasanta Sadhukhan wrote: +1 Regards Prasanta On 11/8/2017 11:58 AM, Muneer Kolarkunnu wrote: Hi Prasanta, I corrected it and please find the updated webrev: http://cr.openjdk.java.net/~akolarkunnu/8190456/webrev.01/

Re: [10] Review Request: JDK-8159142 : Visible artifacts in sun/java2d/SunGraphics2D/DrawImageBilinear.java

2017-11-08 Thread Pankaj Bansal
+ 2d-dev, Phil. Regards, Pankaj Bansal -Original Message- From: Pankaj Bansal Sent: Friday, November 3, 2017 3:11 PM To: Sergey Bylokhov; awt-dev@openjdk.java.net Subject: RE: [10] Review Request: JDK-8159142 : Visible artifacts in sun/java2d/SunGraphics2D/DrawImageBilinear.java Hi Se

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-11-08 Thread Kevin Rushforth
The latest webrev, version 06, looks good to me now. Approved (although I am not a "R"eviewer for AWT). -- Kevin Alexander Zvegintsev wrote: HI Semyon, Please see my answer to Dmitry Hi Dmitry, From my understanding JavaFX stage can't be easily integrated in JDK to support orderWindow()

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-11-08 Thread Semyon Sadetsky
Looks good. --Semyon On 11/07/2017 06:59 PM, Alexander Zvegintsev wrote: HI Semyon, Please see my answer to Dmitry Hi Dmitry, From my understanding JavaFX stage can't be easily integrated in JDK to support orderWindow() approach, addChildWindow() is a native(and the simplest) way to ma

Re: [10] Review request for 8189201: [macosx] NotSerializableException during JFrame with MenuBar serialization

2017-11-08 Thread Semyon Sadetsky
On 11/07/2017 12:54 PM, Phil Race wrote: > The fields cannot be changed to transient because this would break the logic after deserialization of the component. Can you explain what logic would be broken since changing these to transient looks tempting .. Some evnts would not reach the access

RFR: 8181139: Memory leak in awt_Font.cpp / AwtFont::Create

2017-11-08 Thread Philip Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8181139 Webrev : http://cr.openjdk.java.net/~prr/8181139/ if we aren't using / returning the awtFont C object we should free (delete) it before returning to avoid a leak in this theoretical situation. The object has only just been allocated and doe

Re: RFR: 8181139: Memory leak in awt_Font.cpp / AwtFont::Create

2017-11-08 Thread semyon . sadetsky
Should not it be deleted in the catch block as well? --Semyon On 11/8/17 4:13 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8181139 Webrev : http://cr.openjdk.java.net/~prr/8181139/ if we aren't using / returning the awtFont C object we should free (delete) it before r