Thank you Sergey for your review.
Thanks and regards,
Shashi
> On 04-Dec-2017, at 1:03 PM, Sergey Bylokhov
> wrote:
>
> Looks fine.
>
> On 27/11/2017 21:16, Shashidhara Veerabhadraiah wrote:
>> Hi Sergey, Here is the Webrev containing fixes for your comments.
>> http://cr.openjdk.java.net/~sv
Hi Shashi,
Shouldn't the BUTTON1_DOWN_MASK be added to the modifiers of the action?
--Semyon
On 11/27/2017 09:16 PM, Shashidhara Veerabhadraiah wrote:
Hi Sergey, Here is the Webrev containing fixes for your comments.
http://cr.openjdk.java.net/~sveerabhadra/8146537/webrev.01/
Thanks and rega
Hi Semyon, Thank for your review.
BUTTON1_DOWN_MASK upon the GetJavaModifiers() provide if the left mouse button
virtual key is pressed or not. Currently we are unable to capture left button
click state using the ::GetKeyState(). The event NIN_BALLONUSERCLICK is
generated only upon the left mou
Hello,
Could you please approve the following backport of the fix to 8u-dev?
The patch from JDK9 applies cleanly except for copyright year updates;
all code hunks apply cleanly.
Semyon,
Could you please review the changes?
Webrev: http://cr.openjdk.java.net/~aivanov/8179665/jdk8/webrev.0/
JBS
Approved
-Rob
On 04/12/17 19:17, Alexey Ivanov wrote:
> Hello,
>
> Could you please approve the following backport of the fix to 8u-dev?
>
> The patch from JDK9 applies cleanly except for copyright year updates;
> all code hunks apply cleanly.
>
> Semyon,
>
> Could you please review the c
..pending review!
-Rob
On 04/12/17 21:33, Rob McKenna wrote:
> Approved
>
> -Rob
>
> On 04/12/17 19:17, Alexey Ivanov wrote:
> > Hello,
> >
> > Could you please approve the following backport of the fix to 8u-dev?
> >
> > The patch from JDK9 applies cleanly except for copyright year u
Hello.
Please review small cleanup for jdk10.
Bug: https://bugs.openjdk.java.net/browse/JDK-8193012
Webrev can be found at: http://cr.openjdk.java.net/~serb/8193012/webrev.00
The fix for JDK-8129854[1] missed some fields in AWTEvent class which
became unused.
[1] http://hg.openjdk.java.net/j
