[JDK-8252015: [macos11] java.awt.TrayIcon requires updates for template
images](https://bugs.openjdk.java.net/browse/JDK-8252015)
### Problem
According to Apple's human interface guidelines, developers should use template
images for tray icons. This way icons
look good when desktop theme or wallp
On Mon, 28 Sep 2020 15:20:33 GMT, Alexander Zuev wrote:
> Moving review from Mercurial. See
> https://mail.openjdk.java.net/pipermail/awt-dev/2020-August/016078.html for
> previous
> iteration.
@mrserb Can you review this?
-
PR: https://git.openjdk.java.net/jdk/pull/380
On Fri, 2 Oct 2020 16:27:00 GMT, Victor Dyakov wrote:
>> Moving review from Mercurial. See
>> https://mail.openjdk.java.net/pipermail/awt-dev/2020-August/016078.html for
>> previous
>> iteration.
>
> @mrserb Can you review this?
@aivanov-jdk Can you review this?
-
PR: https://gi
On Sun, 27 Sep 2020 22:16:22 GMT, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk.
>
> Old review request:
> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html
>
>
> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it
> should be fine f
On Fri, 2 Oct 2020 16:46:11 GMT, Victor Dyakov wrote:
>> Hello.
>> Please review the fix for jdk.
>>
>> Old review request:
>> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html
>>
>>
>> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it
>> should be
On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
> priva
On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
> priva
On Fri, 2 Oct 2020 18:35:25 GMT, Phil Race wrote:
>> We have a number of missing javadoc tags and comments in the desktop module.
>> Most of the missing comments are related to the serialized form.
>>
>> The fix:
>> - Adds missing comments to the non-static/non-transient fields(even
>> privat
On Fri, 2 Oct 2020 16:29:08 GMT, Victor Dyakov wrote:
>> @mrserb Can you review this?
>
> @aivanov-jdk Can you review this?
I still suggest to try the approach recommended here:
https://mail.openjdk.java.net/pipermail/awt-dev/2020-August/016074.html
On 29.05.2020 14:35, Alexey Ivanov wrote:
>
The "discardingMouseEvents" flag in the SunDragSourceContextPeer class is used
on the different threads without any
synchronization.
-
Commit messages:
- Update SunDragSourceContextPeer.java
Changes: https://git.openjdk.java.net/jdk/pull/491/files
Webrev: https://webrevs.openjdk.j
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
> private) of the "serializable" classes
> - Adds comments to th
On Fri, 2 Oct 2020 19:46:10 GMT, Phil Race wrote:
>> I think the main thing here is I would separate out removing the duplicate
>> PeerFixer into a new bug.
>>
>> I also see that the CSR is still just a pure template.
>
>> I need advice about what exact change should be reviewed in the CSR(exce
This bug is extracted from the JDK-8251123. Instead of specifying this
old/unused class, I suggest to delete it.
This is the comment added to this class in JDK 1.1.1:
==
/*
* In JDK 1.1.1, the pkg private class java.awt.PeerFixer was moved to
* become an inner class
On Sat, 3 Oct 2020 03:57:21 GMT, Sergey Bylokhov wrote:
>>> I need advice about what exact change should be reviewed in the CSR(except
>>> PeerFixer removal)
>>
>> Probably almost all of it.
>
> The PeerFixer is extracted to the separate CR:
> https://bugs.openjdk.java.net/browse/JDK-8253965
>
14 matches
Mail list logo
