Re: RFR: 6422025: ThemeReader.cpp can be updated for VC7

2020-11-06 Thread Sergey Bylokhov
On Fri, 6 Nov 2020 08:51:46 GMT, Sergey Bylokhov wrote: > Some of the type definitions have been imported from `UxTheme.h` to the > `ThemeReader.cpp` because at that time we supported the windows OS below XP > as well as VC6. > > It is time to use `UxTheme.h ` directly, note I did not change h

RFR: 6422025: ThemeReader.cpp can be updated for VC7

2020-11-06 Thread Sergey Bylokhov
Some of the type definitions have been imported from `UxTheme.h` to the `ThemeReader.cpp` because at that time we supported the windows OS below XP as well as VC6. It is time to use `UxTheme.h ` directly, note I did not change how we load this library(JDK_LoadSystemLibrary(), as suggested in th

Re: RFR: 6422025: ThemeReader.cpp can be updated for VC7

2020-11-06 Thread Alexey Ivanov
On Fri, 6 Nov 2020 08:51:46 GMT, Sergey Bylokhov wrote: > Some of the type definitions have been imported from `UxTheme.h` to the > `ThemeReader.cpp` because at that time we supported the windows OS below XP > as well as VC6. > > It is time to use `UxTheme.h ` directly, note I did not change h

Re: RFR: 6422025: ThemeReader.cpp can be updated for VC7

2020-11-06 Thread Sergey Bylokhov
On Fri, 6 Nov 2020 18:17:30 GMT, Alexey Ivanov wrote: >> Some of the type definitions have been imported from `UxTheme.h` to the >> `ThemeReader.cpp` because at that time we supported the windows OS below XP >> as well as VC6. >> >> It is time to use `UxTheme.h ` directly, note I did not chang

Re: RFR: 6422025: ThemeReader.cpp can be updated for VC7

2020-11-06 Thread Alexey Ivanov
On Fri, 6 Nov 2020 08:51:46 GMT, Sergey Bylokhov wrote: > Some of the type definitions have been imported from `UxTheme.h` to the > `ThemeReader.cpp` because at that time we supported the windows OS below XP > as well as VC6. > > It is time to use `UxTheme.h ` directly, note I did not change h

Re: RFR: 6422025: ThemeReader.cpp can be updated for VC7

2020-11-06 Thread Alexey Ivanov
On Fri, 6 Nov 2020 22:09:52 GMT, Sergey Bylokhov wrote: >> src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp line 126: >> >>> 124: DTRACE_PRINTLN("Loaded UxTheme.dll\n"); >>> 125: OpenThemeDataFunc = >>> (PFNOPENTHEMEDATA)GetProcAddress(hModThemes, >>> 126:

Integrated: 6422025: ThemeReader.cpp can be updated for VC7

2020-11-06 Thread Sergey Bylokhov
On Fri, 6 Nov 2020 08:51:46 GMT, Sergey Bylokhov wrote: > Some of the type definitions have been imported from `UxTheme.h` to the > `ThemeReader.cpp` because at that time we supported the windows OS below XP > as well as VC6. > > It is time to use `UxTheme.h ` directly, note I did not change h

Re: RFR: 8225116: Test OwnedWindowsLeak.java intermittently fails

2020-11-06 Thread Sergey Bylokhov
On Sat, 7 Nov 2020 06:55:09 GMT, Sergey Bylokhov wrote: > This test rarely fails in the past on some configurations but was never a > problem listed, and according to the history of CI, it fails 2 times on its > own this year. > > There are two possible reasons for the failure: > 1. At that ti

RFR: 8225116: Test OwnedWindowsLeak.java intermittently fails

2020-11-06 Thread Sergey Bylokhov
This test rarely fails in the past on some configurations but was never a problem listed, and according to the history of CI, it fails 2 times on its own this year. There are two possible reasons for the failure: 1. At that time we had a memory leak, which was fixed. 2. The test works too fast a

RFR: 6278172: TextComponent.getSelectedText() throws StringIndexOutOfBoundsException

2020-11-06 Thread Sergey Bylokhov
The text components are implements as wrappers over the "native" peers. Most of the functionality is provided by the peers not wrappers like TextArea/TextField. The current bug occurs in the TextArea/TextField when the native peer was created yet. The steps to reproduce: 1. Sets the long text