Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-20 Thread Dmitry Markov
On Wed, 20 Jan 2021 07:35:18 GMT, Ichiroh Takiguchi wrote: >> How do the native components work in that case like awt textarea or external >> apps like notepad? > >> How do the native components work in that case like awt textarea or external >> apps like notepad? > > I tested TextField+TextF

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-20 Thread Alexey Ivanov
On Tue, 19 Jan 2021 13:18:22 GMT, Dmitry Markov wrote: > > The fix commits the unconfirmed composition string. Committing is better > > than discarding. Is it possible to preserve the > > state and to leave the string uncommitted? > > The fix reverts the previous (correct) behaviour back. Acco

Re: RFR: 8252015: [macos11] java.awt.TrayIcon requires updates for template images [v2]

2021-01-20 Thread Peter Zhelezniakov
On Sun, 3 Jan 2021 09:17:44 GMT, Aleksei Voitylov wrote: >> Marked as reviewed by serb (Reviewer). > > @mrserb thank you for the review of the issue. Could you review the > associated JDK-8255597 CSR as well? Sure, but I can't find this line in the bug report. Do you mean this one (https://bug

Re: RFR: 8252015: [macos11] java.awt.TrayIcon requires updates for template images

2021-01-20 Thread Tres Finocchiaro
On Wed, 20 Jan 2021 12:40:58 GMT, Peter Zhelezniakov wrote: >> @petermz do you mind editing the original ~~bug report~~ PR description, >> incase this ~~bug report~~ PR is referenced in the future: >> >> - Add a new system property, `java.awt.enableTemplateImages`, ... >> + Add a new system pro

Re: RFR: 8252015: [macos11] java.awt.TrayIcon requires updates for template images

2021-01-20 Thread Tres Finocchiaro
On Fri, 2 Oct 2020 11:08:23 GMT, Peter Zhelezniakov wrote: > [JDK-8252015: [macos11] java.awt.TrayIcon requires updates for template > images](https://bugs.openjdk.java.net/browse/JDK-8252015) > > ### Problem > According to Apple's human interface guidelines, developers should use > template i

Re: RFR: 8252015: [macos11] java.awt.TrayIcon requires updates for template images

2021-01-20 Thread Tres Finocchiaro
On Tue, 6 Oct 2020 08:19:25 GMT, Peter Zhelezniakov wrote: >> Hi, Peter. You are welcome! >> Just an initial question about the template images, can you please provide >> some steps to reproduce this bug and so it will be possible to check that >> the fix solves it. > > Hi Sergey, and thanks fo

Re: RFR: 8252015: [macos11] java.awt.TrayIcon requires updates for template images

2021-01-20 Thread Peter Zhelezniakov
On Wed, 20 Jan 2021 14:36:46 GMT, Tres Finocchiaro wrote: >> Sure, but I can't find this line in the bug report. Do you mean this one >> (https://bugs.openjdk.java.net/browse/JDK-8252015) ? >> >> On Jan 19 2021, at 11:33 pm, Tres Finocchiaro >> wrote: >>> >>> >>> @petermz (https://github.com

Re: RFR: 8239894: Xserver crashes when the wrong high refresh rate is used

2021-01-20 Thread Alexander Zuev
On Tue, 19 Jan 2021 00:57:31 GMT, Sergey Bylokhov wrote: > We use two different approaches to listing the display modes on the system: > - For single-screen configuration use version 1.1 protocol > XRRGetScreenInfo/XRRConfigRates/XRRConfigSizes > - For multi-screen configuration use version 1.