Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v7]

2021-02-12 Thread Ajit Ghaisas
On Thu, 11 Feb 2021 21:04:16 GMT, Gerard Ziemski wrote: >> I guess you will only see this if `Metal API Validation Enabled` > > Which actually begs a question of whether we tested with `Metal API > Validation Enabled` ? Thanks @gerard-ziemski for bringing out this important observation. It clea

Re: RFR: 8257414: Drag n Drop target area is wrong on high DPI systems [v3]

2021-02-12 Thread Olga Mikhaltsova
> Please, review this small fix for drag-n-drop on Linux with HiDPI turned on! > > This bug is due to the following reason: while scaling Java recalculates > resolution (W x H) according to sun.java2d.uiScale (W/SCALE x H/SCALE) and > works inside these new coordinates but at the same time the e

Re: RFR: 8257414: Drag n Drop target area is wrong on high DPI systems [v2]

2021-02-12 Thread Olga Mikhaltsova
On Sat, 6 Feb 2021 02:26:16 GMT, Sergey Bylokhov wrote: >> Olga Mikhaltsova has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8257414: Drag n Drop target area is wrong on high DPI systems > > src/java.desktop/unix/classes/sun/awt/X11/XDnDD

RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol

2021-02-12 Thread Alexander Zuev
8261351: Create implementation for NSAccessibilityRadioButton protocol - Commit messages: - 8261351: Create implementation for NSAccessibilityRadioButton protocol Changes: https://git.openjdk.java.net/jdk/pull/2561/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2561&ra

Re: RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol

2021-02-12 Thread Pankaj Bansal
On Sat, 13 Feb 2021 05:01:17 GMT, Alexander Zuev wrote: > 8261351: Create implementation for NSAccessibilityRadioButton protocol src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m line 39: > 37: AWT_ASSERT_APPKIT_THREAD; > 38: id value = [self accessibility

Re: RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol

2021-02-12 Thread Pankaj Bansal
On Sat, 13 Feb 2021 05:01:17 GMT, Alexander Zuev wrote: > 8261351: Create implementation for NSAccessibilityRadioButton protocol src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.h line 35: > 33: > 34: }; > 35: - (id)accessibilityValue; The NSAccessibilityRadioBut

Re: RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol [v2]

2021-02-12 Thread Alexander Zuev
> 8261351: Create implementation for NSAccessibilityRadioButton protocol Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Internal variable eliminated. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2561/file

Re: RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol [v2]

2021-02-12 Thread Alexander Zuev
On Sat, 13 Feb 2021 05:31:18 GMT, Pankaj Bansal wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Internal variable eliminated. > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.h >

Re: RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol [v2]

2021-02-12 Thread Pankaj Bansal
On Sat, 13 Feb 2021 05:55:02 GMT, Alexander Zuev wrote: >> 8261351: Create implementation for NSAccessibilityRadioButton protocol > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Internal variable eliminated. Marked as re