Re: RFR: 8261785: Calling "main" method in anonymous nested class crashes the JVM [v3]

2021-03-17 Thread Alan Bateman
On Tue, 16 Mar 2021 17:49:42 GMT, Henry Jen wrote: > > Using an anonymous class for the main class looks strange and hard to > > believe anyone is relying on this. I wonder if we should do more checking > > LauncherHelper.validateMainClass to reject cases like this. > > I raised that same ques

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Sun, 14 Mar 2021 12:06:08 GMT, Alan Bateman wrote: > the - PR: https://git.openjdk.java.net/jdk/pull/2920

Withdrawn: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/2920

Re: RFR: 8261785: Calling "main" method in anonymous nested class crashes the JVM [v3]

2021-03-17 Thread Henry Jen
On Wed, 17 Mar 2021 08:55:54 GMT, Alan Bateman wrote: > > > Using an anonymous class for the main class looks strange and hard to > > > believe anyone is relying on this. I wonder if we should do more checking > > > LauncherHelper.validateMainClass to reject cases like this. > > > > > > I rai

Re: RFR: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

2021-03-17 Thread Alexander Zuev
On Wed, 17 Mar 2021 01:39:10 GMT, Sergey Bylokhov wrote: >> Initial implementation >> Moved the CAccessibility ignore list initialization to the new code >> Some cleanup >> Expose a new API - isAccessibilityElement instead of deprecated >> accessibilityIsIgnored > > src/java.desktop/macosx/nativ

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Sun, 14 Mar 2021 12:06:08 GMT, Alan Bateman wrote: > > > Have you looked at narrowing the use of the SuppressWarnings to local > variable declarations to avoid adding it to some of these methods? in all cases either: - the class or method itself is being deprecated - the method takes a d

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Alan Bateman
On Wed, 17 Mar 2021 16:44:19 GMT, Andy Herrick wrote: > I cannot find any instances where the scope can be narrowed Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods? - PR: https://git.openjdk.java.net/jdk/pull/2920

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Wed, 17 Mar 2021 19:02:39 GMT, Alan Bateman wrote: > > > > I cannot find any instances where the scope can be narrowed > > Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. > stateChanged, and other non-trivial methods? These have the code pattern such as: } else if (c in

Re: RFR: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

2021-03-17 Thread Sergey Bylokhov
On Mon, 15 Mar 2021 17:21:01 GMT, Alexander Zuev wrote: > Initial implementation > Moved the CAccessibility ignore list initialization to the new code > Some cleanup > Expose a new API - isAccessibilityElement instead of deprecated > accessibilityIsIgnored Marked as reviewed by serb (Reviewer).