On Wed, 26 May 2021 13:49:24 GMT, Alexey Ushakov wrote:
> Set black color for underlying window background to perform correct blending
> operations in metal with window surface destination
Yes, looks like we have the flashing problem back. It seems more serious than
this particular bug.
We hav
On Wed, 26 May 2021 21:39:19 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 87:
>>
>>> 85: }
>>> 86:
>>> 87: if (implComplete && icon.getIconWidth() != size) {
>>
>> Why the size of the returned images might be di
On Thu, 27 May 2021 16:16:19 GMT, Sergey Bylokhov wrote:
> Is this requirement is so important? can we return an MRI(same as on Windows)
> which will have just one resolution?
We might - when the implementation will be done on other platforms. Probably it
will be done by me, probably - by some
On Mon, 24 May 2021 13:53:34 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote:
>> The code change refactors classes that have a `SuppressWarnings("removal")`
>> annotation that covers more than 50KB of code. The big annotation is often
>> quite faraway from the actual deprecated API usage it is suppressing, and
>> with
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
On Mon, 8 Mar 2021 13:22:07 GMT, Alexander Zuev wrote:
> Fix updated after first round of review.
This pull request has now been integrated.
Changeset: 7f52c50b
Author:Alexander Zuev
URL:
https://git.openjdk.java.net/jdk/commit/7f52c50ba32eecf5f379f8db30ac6a5cc50b3b66
Stats: 408
On Wed, 26 May 2021 17:51:55 GMT, Alexander Zvegintsev
wrote:
>> This fix is to explicitly specify that `Taskbar::getIconImage` may return an
>> object different from passed to `Taskbar::setIconImage`.
>>
>> Actually it is always returns a different object on macOS(the only OS which
>> suppor
On Thu, 27 May 2021 16:38:02 GMT, Alexander Zuev wrote:
>> Is this requirement is so important? can we return an MRI(same as on
>> Windows) which will have just one resolution? Otherwise what the user should
>> do if the requested size was 32x32 but returned image will be 21x21? Paint
>> the s
On Fri, 7 May 2021 17:53:49 GMT, Alexander Zuev wrote:
>> This comment is also about the case of not fetching icons of sizes smaller
>> than requested size.
>
> Sorry, missed that in my latest fix. Indeed there is no legitimate ways to
> set scaling factor to less than 100% on Windows so yes, o
On Thu, 27 May 2021 20:16:25 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Thu, 27 May 2021 17:42:56 GMT, Phil Race wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update FtpClient.java
>
> src/java.desktop/share/classes/java/awt/Component.java line 630:
>
>> 628: }
>> 629:
>>
On Fri, 28 May 2021 02:50:55 GMT, Weijun Wang wrote:
>> src/java.desktop/share/classes/java/awt/Component.java line 630:
>>
>>> 628: }
>>> 629:
>>> 630: @SuppressWarnings("removal")
>>
>> I'm confused. I thought the reason this wasn't done in the JEP
>> implementation PR is be
On Fri, 28 May 2021 03:12:35 GMT, Phil Race wrote:
>> There *is* a tiny refactoring here: a new variable `s2` is introduced so the
>> 2nd `doPrivileged` call on line 636 is now also in a declaration statement
>> (for `s2`) and therefore annotatable. Without this I cannot add the
>> annotation
14 matches
Mail list logo
