Re: RFR: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility [v4]

2021-07-14 Thread Artem Semenov
> 8267385: Create NSAccessibilityElement implementation for > JavaComponentAccessibility > This pull request contains solutions for the following tickets: > * JDK-8267385 Create NSAccessibilityElement implementation for > JavaComponentAccessibility; > * JDK-8262031 Create implementation for NSAcc

RFR: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

2021-07-14 Thread Alexander Zuev
Make fallback code for inaccessible file to return multiresolution icon Remove test from ProblemList - Commit messages: - 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows Changes: https://git.openjdk.java.net/jdk/pull/4777/files Webrev: https:/

Re: RFR: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

2021-07-14 Thread Alexey Ivanov
On Wed, 14 Jul 2021 11:19:53 GMT, Alexander Zuev wrote: > Make fallback code for inaccessible file to return multiresolution icon > Remove test from ProblemList So, essentially all the icons returned are MultiResolutionIcon even if there's only one icon, right? - PR: https://git.o

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v9]

2021-07-14 Thread Сергей Цыпанов
On Tue, 13 Jul 2021 13:04:36 GMT, Attila Szegedi wrote: >> src/java.base/share/classes/java/util/BitSet.java line 1040: >> >>> 1038: h ^= words[i] * (i + 1); >>> 1039: >>> 1040: return Long.hashCode(h); >> >> Here `>>` instead of `>>>` in original code seems to be a typo >

Re: RFR: 8268113: Re-use Long.hashCode() where possible [v10]

2021-07-14 Thread Сергей Цыпанов
> There is a few JDK classes duplicating the contents of Long.hashCode() for > hash code calculation. They should explicitly delegate to Long.hashCode(). Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

2021-07-14 Thread Alexander Zuev
On Wed, 14 Jul 2021 11:56:15 GMT, Alexey Ivanov wrote: > So, essentially all the icons returned are MultiResolutionIcon even if > there's only one icon, right? It was a multiresolution icon even with one icon inside but only when the native and requested icon resolutions do not match. Now it w

Re: RFR: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

2021-07-14 Thread Alexey Ivanov
On Wed, 14 Jul 2021 11:19:53 GMT, Alexander Zuev wrote: > Make fallback code for inaccessible file to return multiresolution icon > Remove test from ProblemList Marked as reviewed by aivanov (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4777

Integrated: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

2021-07-14 Thread Alexander Zuev
On Wed, 14 Jul 2021 11:19:53 GMT, Alexander Zuev wrote: > Make fallback code for inaccessible file to return multiresolution icon > Remove test from ProblemList This pull request has now been integrated. Changeset: a033866d Author:Alexander Zuev URL: https://git.openjdk.java.net/jdk