AWT Dev hg: jdk8/awt/jdk: 7189112: java.beans.Introspector misses write methods

2012-08-20 Thread sergey . malenkov
Changeset: fbf21a561c45 Author:malenkov Date: 2012-08-20 13:38 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fbf21a561c45 7189112: java.beans.Introspector misses write methods Reviewed-by: rupashka ! src/share/classes/java/beans/PropertyDescriptor.java +

Re: AWT Dev [8] Review request for 7186371: [macosx] Main menu shortcuts not displayed (7u6 regression)

2012-08-20 Thread Sergey Bylokhov
Does anybody has a chance to review it? Thanks. 13.08.2012 19:26, Sergey Bylokhov wrote: Thanks Leonid. Does anybody has a chance to review it? 08.08.2012 10:20, Leonid Romanov wrote: Looks reasonable. -Original Message- From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com]

Re: AWT Dev [8] Review request for CR 7124375: [macosx] Focus isn't transfered as expected between components

2012-08-20 Thread Artem Ananiev
Hi, Leonid, I don't see anything obviously wrong with the fix, however it must be reviewed by at least one more person. Thanks, Artem On 8/17/2012 9:59 PM, Leonid Romanov wrote: Hi, Please review a fix for CR 7124375: [macosx] Focus isn't transfered as expected between components. The main

Re: AWT Dev [8] Review request for 7186109: Simplify lock machinery for PostEventQueue EventQueue

2012-08-20 Thread Anthony Petrov
Hi Oleg, 1. src/share/classes/java/awt/EventQueue.java The comment block is about the lock()/unlock() synchronized block, so I suggest to move a call to flushPendingEvents() above the comment for clarity. 2. src/share/classes/sun/awt/SunToolkit.java 2a) We must synchronize access to the

Re: AWT Dev [7u8] Review request for 7189350: Fix failed for CR 7162144

2012-08-20 Thread Anthony Petrov
We do not reset the status ourselves. The interrupted status has already been reset by code that invoked interrupted() and thrown the InterruptedException in the first place. There's nothing wrong with that, though, because we reset the doDispatch flag upon processing the exception. We now