Re: RFR: 8257414: Drag n Drop target area is wrong on high DPI systems [v3]

2021-02-26 Thread Sergey Bylokhov
On Fri, 12 Feb 2021 21:43:56 GMT, Olga Mikhaltsova wrote: >> Please, review this small fix for drag-n-drop on Linux with HiDPI turned on! >> >> This bug is due to the following reason: while scaling Java recalculates >> resolution (W x H) according to sun.java2d.uiScale (W/SCALE x H/SCALE)

Re: RFR: 8262161 Refactor manual I/O stream copying to new convinient methods in java.desktop

2021-02-26 Thread Phil Race
On Mon, 21 Dec 2020 07:54:17 GMT, Andrey Turbanov wrote: > Cleanup code to use new handy methods in > `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy: > 1. java.io.InputStream#readAllBytes > 2. java.io.InputStream#transferTo > 3. java.nio.file.Files#copy > > Similar

Re: RFR: 8262161 Refactor manual I/O stream copying to new convinient methods in java.desktop

2021-02-26 Thread Phil Race
On Fri, 26 Feb 2021 20:21:21 GMT, Sergey Bylokhov wrote: >> src/java.desktop/unix/classes/sun/print/UnixPrintJob.java line 601: >> >>> 599: try (BufferedInputStream bin = new >>> BufferedInputStream(instream); >>> 600: BufferedOutputStream bout = new >>>

Re: RFR: 8262161 Refactor manual I/O stream copying to new convinient methods in java.desktop

2021-02-26 Thread Sergey Bylokhov
On Wed, 24 Feb 2021 20:48:29 GMT, Phil Race wrote: >> Cleanup code to use new handy methods in >> `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy: >> 1. java.io.InputStream#readAllBytes >> 2. java.io.InputStream#transferTo >> 3. java.nio.file.Files#copy >> >> Similar

RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

2021-02-26 Thread Alexander Scherbatiy
Printing text using GlyphVector outline has bad quality on printers with low DPI on Windows. The GDI system used for text printing on Windows accepts only integer path coordinates. Rounding GlyphVector outline coordinates leads to distorted printed text. The issue had been reported as

Re: RFR: JDK-8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c

2021-02-26 Thread Alexey Ivanov
On Fri, 26 Feb 2021 14:19:03 GMT, Matthias Baesken wrote: > The function wcstombsdmp is called at a few places in awt_InputMethod.c. > This function needs checking of a NULL return value and freeing of the memory > allocated by this function. However this is missing at one place in the file.

Re: RFR: JDK-8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c

2021-02-26 Thread Alexander Zvegintsev
On Fri, 26 Feb 2021 14:19:03 GMT, Matthias Baesken wrote: > The function wcstombsdmp is called at a few places in awt_InputMethod.c. > This function needs checking of a NULL return value and freeing of the memory > allocated by this function. However this is missing at one place in the file.

Re: RFR: JDK-8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c

2021-02-26 Thread Prasanta Sadhukhan
On Fri, 26 Feb 2021 14:19:03 GMT, Matthias Baesken wrote: > The function wcstombsdmp is called at a few places in awt_InputMethod.c. > This function needs checking of a NULL return value and freeing of the memory > allocated by this function. However this is missing at one place in the file.

Integrated: JDK-8262420: typo: @implnote in java.desktop module

2021-02-26 Thread Jonathan Gibbons
On Thu, 25 Feb 2021 23:15:03 GMT, Jonathan Gibbons wrote: > Please review some doc changes in `java.awt.TrayIcon`. > > Note, the fix is more than the 1-character fix for the typo detected by > doclint. The changes are: > > 1. Fix the name of the `@implNote` tag > 2. Remove the redundant ``

RFR: JDK-8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c

2021-02-26 Thread Matthias Baesken
The function wcstombsdmp is called at a few places in awt_InputMethod.c. This function needs checking of a NULL return value and freeing of the memory allocated by this function. However this is missing at one place in the file. - Commit messages: - JDK-8262461 Changes: