: Ambarish Rapte
Sent: Wednesday, January 27, 2016 12:09 PM
To: Ajit Ghaisas; Sergey Bylokhov; Semyon Sadetsky; awt-dev@openjdk.java.net
Subject: RE: Review request for 8005918 : [TESTBUG] There are no
'Frame Enter' messages for both frames, only 'Button Enter' message.
Hi Ajit,
Can this test
Hi,
Please review the fix for JDK9.
Webrev: http://cr.openjdk.java.net/~arapte/ajit/8005918/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8005918
Changes :
Added a test to test mouse move events on lightweight components as
compared to
Hi,
Bug : https://bugs.openjdk.java.net/browse/JDK-6353518
Issue : (Text from bug description)
An attempt to create a WritableRaster via
Raster.createWritableRaster(SampleModel sm, DataBuffer db, Point location)
using a custom DataBuffer causes an erroneous
Hi,
Adding delay in test code in main thread fixes this test timeout.
I considered adding some delay in Robot.waitForIdle() method so that the
calling thread yields, but realized that, it will have undesirable effect of
slowing down test runs as many tests use that method.
This
Hi,
Bug : https://bugs.openjdk.java.net/browse/JDK-8074829
This bug is to remove warning suppressions from makefile and fix the
warnings for libawt_headless library.
I have removed following warning suppressions & fixed the warnings for
libawt_headless library.
Thanks Yuri.
Here is the updated webrev with suggested change.
http://cr.openjdk.java.net/~aghaisas/8031423/webrev.01/
Regards,
Ajit
-Original Message-
From: Yuri Nesterenko
Sent: Thursday, April 14, 2016 6:48 PM
To: Ajit Ghaisas; Sergey Bylokhov; awt-dev@openjdk.java.net
Subject: Re
Thanks Phil.
I have updated the test as discussed. Here is the updated webrev.
http://cr.openjdk.java.net/~aghaisas/8159956/webrev.01/
Regards,
Ajit
From: Philip Race
Sent: Wednesday, July 13, 2016 10:11 PM
To: Ajit Ghaisas
Cc: Semyon Sadetsky; awt-dev@openjdk.java.net
Subject: Re: [9
Thanks Phil for the review.
Please find my answers below.
Semyon, can you please comment on Phil's question below?
Regards,
Ajit
-Original Message-
From: Phil Race
Sent: Wednesday, July 06, 2016 2:02 AM
To: Ajit Ghaisas
Cc: Sergey Bylokhov; Erik Joelsson; 2d-dev; awt-dev
This fixes the build. I checked on Windows7 x64.
Regards,
Ajit
From: Prem Balakrishnan
Sent: Thursday, February 16, 2017 3:48 PM
To: Prasanta Sadhukhan; Ajit Ghaisas
Cc: awt-dev@openjdk.java.net
Subject: Review Request : JDK-8175066 Compilation error due to tag in
JDK-8162959
Hi
Message-
From: Sergey Bylokhov
Sent: Thursday, September 29, 2016 6:07 PM
To: Ajit Ghaisas; awt-dev@openjdk.java.net; Semyon Sadetsky; Ambarish Rapte
Subject: Re: [9] Fix for JDK-8058950 : [TESTBUG] There is no F1 dialog when the
case loading,so we can't restore it.
Should this test start on OSX
Test looks good after suggested cleanup.
Regards,
Ajit
-Original Message-
From: Sergey Bylokhov
Sent: Wednesday, September 14, 2016 11:38 PM
To: Manajit Halder
Cc: Rajeev Chamyal; Ajit Ghaisas; awt-dev@openjdk.java.net
Subject: Re: [9] Review request for JDK-8163270: [macosx] Robot(gc
The fix looks good.
Regards,
Ajit
From: Ambarish Rapte
Sent: Monday, September 19, 2016 4:15 PM
To: Sergey Bylokhov; Semyon Sadetsky; Ajit Ghaisas; awt-dev@openjdk.java.net
Subject: Review request for JDK-8166015: [PIT][TEST_BUG] stray character in
java/awt/Focus
Hi,
Fix of HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8165232"JDK-8165232 has fixed the
'deprecated' warnings from libawt_xawt.
Now, only removing warning suppression from makefile remains. This webrev
does it.
http://cr.openjdk.java.net/~aghaisas/8160146/webrev.0/
Hi,
Request you to review a test fix.
Bug : https://bugs.openjdk.java.net/browse/JDK-8169043
Fix : http://cr.openjdk.java.net/~aghaisas/8169043/webrev.0/
Changes are :
1) Test is made to be run on Windows only.
2) Pass/Fail status was not reported correctly. It has been
Hi Prem,
I know this is compilation fix, but still few corrections can be made to
the test.
1. Please replace generic imports to specific class imports.
2. First sentence of the instruction text has a typo - please correct it.
Existing : "Use see a Frame with a button
Looks fine.
Regards,
Ajit
From: Prem Balakrishnan
Sent: Monday, October 24, 2016 3:16 PM
To: Ajit Ghaisas; Alexander Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net
Subject: RE: Review Request : JDK-8168292 [TestBug]Test
java/awt/TrayIcon/DragEventSource/DragEventSource.java fails
Hi,
Please review a quick-fix where a missed jtreg tag has been added.
Bug : https://bugs.openjdk.java.net/browse/JDK-8168470
Fix : http://cr.openjdk.java.net/~aghaisas/8168470/webrev.0/
Request you to review.
Regards,
Ajit
on Linux - it will be addressed in JDK-8170390.
This test fix will help in reproducing JDK-8133719 consistently on Windows and
Mac.
Regards,
Ajit
From: Alexandr Scherbatiy
Sent: Wednesday, September 14, 2016 8:33 PM
To: Ajit Ghaisas; Yuri Nesterenko; awt-dev@openjdk.java.net
Subject: Re: [9
Fix looks good.
Regards,
Ajit
From: Alexandr Scherbatiy
Sent: Thursday, October 27, 2016 8:22 PM
To: Prem Balakrishnan; Ajit Ghaisas; awt-dev@openjdk.java.net
Subject: Re: Review Request: 8159132 : [PIT][TEST_BUG]
java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java fails
Looks good.
Regards,
Ajit
-Original Message-
From: Sergey Bylokhov
Sent: Thursday, November 03, 2016 4:08 PM
To: Ambarish Rapte; Ajit Ghaisas; Semyon Sadetsky; awt-dev@openjdk.java.net
Subject: Re: Review Request For 8160766: [TEST_BUG]
java/awt/Focus/DisposedWindow
HI, Ambarish
Can I get another +1 for this fix?
Regards,
Ajit
-Original Message-
From: Erik Joelsson
Sent: Thursday, October 27, 2016 3:30 PM
To: Ajit Ghaisas; build-...@openjdk.java.net; awt-dev@openjdk.java.net
Subject: Re: Fix for JDK-8160146 : Resolve disabled GCC warning
'deprecated
The fix looks good.
Regards,
Ajit
-Original Message-
From: Sergey Bylokhov
Sent: Wednesday, October 12, 2016 8:12 PM
To: Manajit Halder
Cc: awt-dev@openjdk.java.net
Subject: Re: [9] Review request for JDK-8158380: Regression:
java/awt/List/ActionEventTest/ActionEventTest.java
Looks
Hi,
Bug :
https://bugs.openjdk.java.net/browse/JDK-8166980
Issue and Fix :
Fix for HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8147648"JDK-8147648 needs to be
corrected a little.
IconInfo::setScaledSize(int width, int height) method sets scaledWidth,
The fix looks good.
I suggest to replace wildcard import statements with specific ones in both the
files in webrev.
Regards,
Ajit
From: Rahul Singh
Sent: Tuesday, January 03, 2017 6:17 PM
To: awt-dev@openjdk.java.net
Subject: [awt-dev] Request for Approval and Review: JDK-8140329
Change looks fine.
Some correction can be done by replacing wildcard imports by specific imports.
Regards,
Ajit
From: Prem Balakrishnan
Sent: Wednesday, January 04, 2017 4:09 PM
To: Ajit Ghaisas; Prasanta Sadhukhan; awt-dev@openjdk.java.net
Subject: Review Request: JDK-8172009
Hi Semyon,
I had attempted this fix some time back and had run into some regression
for SwingSet2.
There was a crash while using SwingSet2 with GTK look-and-feel with GTK-2.
I do not remember the exact steps, but just playing with SwingSet2 had
produced this crash.
Can you
Good. +1.
Regards,
Ajit
From: Manajit Halder
Sent: Tuesday, November 28, 2017 5:28 PM
To: Ajit Ghaisas
Cc: Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net
Subject: Re: [10] Review request for JDK-8158366: [macosx]
Regression: closed/java/awt/dnd/RecognizedActionTest
1) This test lacks copyright banner at the top
2) init() prints to System.err & returns silently in case of failure - suggest
to capture failure and throw exception.
Regards,
Ajit
-Original Message-
From: Prem Balakrishnan
Sent: Monday, November 27, 2017 12:02 PM
To: Sergey Bylokhov;
Hi Manajit,
The changes look good.
As this is a new test in open, can you please confirm whether it passes on
Windows and Linux as well?
Regards,
Ajit
From: Manajit Halder
Sent: Monday, November 27, 2017 4:35 PM
To: Ajit Ghaisas
Cc: Prem Balakrishnan; Sergey Bylokhov; awt
Can we use existing 'skipPostMessage' member for this check instead of
introducing additional member in LWChoicePeer class?
From: Shashidhara Veerabhadraiah
Sent: Tuesday, July 03, 2018 12:16 PM
To: Krishna Addepalli; awt-dev@openjdk.java.net
Subject: Re: [12]RFR : JDK-8014503: AWT Choice
Hi Krishna,
Thanks for the explanation. Changes look good.
You will need a 'R' reviewer to review this though.
Regards,
Ajit
From: Krishna Addepalli
Sent: Tuesday, July 03, 2018 2:20 PM
To: Ajit Ghaisas; Shashidhara Veerabhadraiah; awt-dev@openjdk.java.net
Subject: RE: [12]RFR
Looks good. +1.
Minor nit-
1. There should be a space between "if" and "("
2. Second string concatenation (+) in System.out.println is not needed
You can fix these while pushing the changeset.
Regards,
Ajit
From: Shashidhara Veerabhadraiah
Sent: Tuesday,
On Tue, 15 Jun 2021 16:57:00 GMT, Alexey Ushakov wrote:
> Implemented blit via compute kernel
What I have observed with this patch is - It does not break all shaped or
translucent windows - but, a manual JCK test does show the black background.
-
PR:
On Fri, 2 Jul 2021 17:49:17 GMT, Alexey Ushakov wrote:
>> Implemented blit via compute kernel
>
> Alexey Ushakov has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR.
On Mon, 5 Jul 2021 15:55:20 GMT, Alexey Ushakov wrote:
>> Implemented blit via compute kernel
>
> Alexey Ushakov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL
>
On Fri, 9 Apr 2021 07:21:57 GMT, Sergey Bylokhov wrote:
>> This is the only place where we use MTLContext.invalidateCurrentContext() -
>> which when processed in MTLRenderQueue - clears some native stuff and nulls
>> out both mtlc and dstOps pointers maintained in MTLRenderQueue.m. I think,
> Refer JBS for 3 issues that this PR addresses.
> In addition, I have corrected an erroneous free() call in the same method I
> was cleaning up.
Ajit Ghaisas has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelate
> Refer JBS for 3 issues that this PR addresses.
> In addition, I have corrected an erroneous free() call in the same method I
> was cleaning up.
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
cleanup unus
On Tue, 6 Apr 2021 14:12:55 GMT, Ajit Ghaisas wrote:
> Refer JBS for 3 issues that this PR addresses.
> In addition, I have corrected an erroneous free() call in the same method I
> was cleaning up.
This pull request has now been integrated.
Changeset: 8fa50ebd
Author:Ajit Gha
pipeline you must specify on command line
> -Dsun.java2d.metal=true (No message will be printed in this case) or
> -Dsun.java2d.metal=True (A message indicating Metal rendering pipeline is
> enabled gets printed)
Ajit Ghaisas has updated the pull request with a new target base
On Fri, 5 Feb 2021 18:42:02 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> make/modules/java.desktop/lib/Awt2dLib
pipeline you must specify on command line
> -Dsun.java2d.metal=true (No message will be printed in this case) or
> -Dsun.java2d.metal=True (A message indicating Metal rendering pipeline is
> enabled gets printed)
Ajit Ghaisas has updated the pull request incrementally
On Mon, 8 Feb 2021 14:22:27 GMT, Kevin Rushforth wrote:
>> I think, a generic name is OK as the path of shader file already has both
>> awt (libawt_lwawt) and java2d in it.
>
> In the source tree, yes, but not in the jdk image where it ends up in
> `$JAVA_HOME/lib/shaders.metallib`. I don't
pipeline you must specify on command line
> -Dsun.java2d.metal=true (No message will be printed in this case) or
> -Dsun.java2d.metal=True (A message indicating Metal rendering pipeline is
> enabled gets printed)
Ajit Ghaisas has updated the pull request incrementally with two addition
On Mon, 8 Feb 2021 16:53:16 GMT, Gerard Ziemski wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> src/java.desktop/macosx/classes/sun/awt
ew comments) are
> tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598
Ajit Ghaisas has updated the pull request incrementally with two additional
commits since the last revision:
- Lanai PR#179 - 8261402 - avu
- Lanai PR#178 - 8261273 - avu
-
Changes:
On Wed, 10 Feb 2021 22:31:12 GMT, Gerard Ziemski wrote:
>> Marked as reviewed by gziemski (Committer).
>
> According to Xcode Instruments leak profile, there are 2 minor memory leaks
> in the Metal rendering pipeline:
>
> `#1 Malloc 80 Bytes 1 0x7fde0d4247b0 80 Bytes
ew comments) are
> tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598
Ajit Ghaisas has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. Th
ew comments) are
> tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598
Ajit Ghaisas has updated the pull request incrementally with two additional
commits since the last revision:
- Lanai PR#181 - 8261143 - aghaisas
- Lanai PR#180 - 8261546 - jdv
-
Chang
Refer JBS for 3 issues that this PR addresses.
In addition, I have corrected an erroneous free() call in the same method I was
cleaning up.
-
Commit messages:
- 8263363 - cleanup
Changes: https://git.openjdk.java.net/jdk/pull/3357/files
Webrev:
ew comments) are
> tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598
Ajit Ghaisas has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contai
On Mon, 8 Feb 2021 18:47:09 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m
>> line 82:
>>
>>> 80: (JNIEnv *env, jclass mtlgc)
>>> 81: {
>>> 82: FILE *f = popen("/usr/sbin/system_profiler SPDisplaysDataType",
>>> "r");
>>
>>
ew comments) are
> tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598
Ajit Ghaisas has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contai
On Thu, 11 Mar 2021 07:40:47 GMT, Alexey Ushakov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Thu, 4 Feb 2021 10:35:02 GMT, Ajit Ghaisas wrote:
> **Description :**
> This is the implementation of [JEP 382 : New macOS Rendering
> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
> It implements a Java 2D internal rendering pipeline for macOS using the Apple
On Tue, 9 Mar 2021 20:18:08 GMT, Sergey Bylokhov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Sun, 7 Mar 2021 22:40:53 GMT, Sergey Bylokhov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Fri, 12 Mar 2021 01:04:22 GMT, Sergey Bylokhov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Fri, 12 Mar 2021 01:01:09 GMT, Sergey Bylokhov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Fri, 12 Mar 2021 10:11:27 GMT, Prasanta Sadhukhan
wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
ew comments) are
> tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598
Ajit Ghaisas has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contai
ew comments) are
> tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598
Ajit Ghaisas has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request cont
> Refer JBS for 3 issues that this PR addresses.
> In addition, I have corrected an erroneous free() call in the same method I
> was cleaning up.
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
log message c
> Refer JBS for 3 issues that this PR addresses.
> In addition, I have corrected an erroneous free() call in the same method I
> was cleaning up.
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
Review fixes
-
On Mon, 15 Feb 2021 18:30:51 GMT, Gerard Ziemski wrote:
>> Changes requested by gziemski (Committer).
>
> I took a look at https://bugs.openjdk.java.net/browse/JDK-8261408 and noticed
> a startup time regression with the Metal rendering pipeline, so I dug a bit
> and here is what I found using
This is the implementation of JEP 382 : New macOS Rendering Pipeline (Metal
rendering pipeline)
JEP Link - https://bugs.openjdk.java.net/browse/JDK-8238361
-
Commit messages:
- Project Lanai Patch
Changes: https://git.openjdk.java.net/jdk/pull/2403/files
Webrev:
ew comments) are
> tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598
Ajit Ghaisas has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contai
ew comments) are
> tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598
Ajit Ghaisas has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request cont
68 matches
Mail list logo
