[14] RFR JDK-8234802 - [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms

Hi All, Please review a test fix for jdk-14. Bug : https://bugs.openjdk.java.net/browse/JDK-8234802 Webrev : http://cr.openjdk.java.net/~trebari/swing/8234802/webrev0/ This i

Re: [14] RFR JDK-8234802 - [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms

The test should dispose the frame on all code paths. > > On 12/5/19 4:06 am, Tejpal Rebari wrote: >> Hi All, >> Please review a test fix for jdk-14. >> Bug : https://bugs.openjdk.java.net/browse/JDK-8234802 >> Webrev : http://cr.openjdk.java.net/~trebari/swing/823

Re: [15] Review Request: 8237222 [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails

Looks good to me. Regards, Tejpal > On 24-Jan-2020, at 3:05 PM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for JDK 15. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8237222 > Fix: http://cr.openjdk.java.net/~serb/8237222/webrev.00 > > To fix the bug in the test a few spe

Fwd: RFR: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual

> Begin forwarded message: > > From: Tejpal Rebari > Subject: RFR: 8239827: The test OpenByUNCPathNameTest.java should > be changed to be manual > Date: 22 May 2020 at 3:32:45 PM IST > To: swing-...@openjdk.java.net > > Hi All, > Please review the following tes

Re: Fwd: RFR: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual

nged only manually. > Regards > Prasanta > On 22-May-20 3:36 PM, Tejpal Rebari wrote: >> >> >>> Begin forwarded message: >>> >>> From: Tejpal Rebari >> <mailto:tejpal.reb...@oracle.com>> >>> Subject: RFR: 8239827: The test OpenByUN

Re: RFR: 8255043: Incorrectly styled copyright text

On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov wrote: > In some files, the copyright text is styled as a JavaDoc comment. > Most of the affected files are tests, only one product file is affected: > src/java.sql/share/classes/javax/sql/package-info.java > > The chenge is trivial: > - /** >

Re: RFR: 8259439: Apply java.io.Serial annotations in java.datatransfer

On Fri, 8 Jan 2021 04:51:50 GMT, Sergey Bylokhov wrote: > Please review the application of `@java.io.Serial` annotation (JDK-8202385) > to types in the datatransfer module to enable stricter compile-time checking > of serialization-related declarations. > > This annotation can be applied to t

Re: RFR: 8264344: Outdated links in JavaComponentAccessibility.m

On Mon, 29 Mar 2021 08:31:48 GMT, Alexander Zuev wrote: > 8264344: Outdated links in JavaComponentAccessibility.m Marked as reviewed by trebari (Committer). - PR: https://git.openjdk.java.net/jdk/pull/3240

RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

Hi All, Please review the following fix for jdk17. Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full Screen when the System Preference -> General -> Prefer Tabs is set to "Full Screen". It is also freezing in normal screen when Prefer Tabs is set to "Always". It doesn

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

On Fri, 9 Apr 2021 07:01:26 GMT, Sergey Bylokhov wrote: > > Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release > > staring from 10.12. > > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > > value changed in macos11. > > But why the option setAl

RFR: 8197811 : Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows

The test PopupPosTest.java fails for windows every time, and was problem listed. This test was added under the JDK-5044150, And the change was specific to XToolkit as mentioned in JDK-5044150. "this change is for XToolkit thus testing it on Linux will be sufficient"/ This test runs fine in linu

Integrated: 8197811 : Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows

On Mon, 19 Apr 2021 09:49:40 GMT, Tejpal Rebari wrote: > The test PopupPosTest.java fails for windows every time, and was problem > listed. > This test was added under the JDK-5044150, And the change was specific to > XToolkit as mentioned in JDK-5044150. > "this change

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

On Sat, 10 Apr 2021 23:22:06 GMT, Philip Race wrote: > It would be interesting to have an enumeration of known and suspected > problems with this. > > * where is it inappropriate UI - if we have an unowned dialog it is really > weird to popup it up in a new tab. > Are just at odds with the m

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

On Fri, 9 Apr 2021 05:42:37 GMT, Tejpal Rebari wrote: > Hi All, > Please review the following fix for jdk17. > > Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full > Screen when the System Preference -> General -> Prefer Tabs is set to "F

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v2]

ndowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. > > Test : Added a manual test and tested on MacOS 10.15 and 11. > All the internal tests run are green. Tejp

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v3]

ndowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. > > Test : Added a manual test and tested on MacOS 10.15 and 11. > All the internal tests run are green. Tejp

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v3]

On Tue, 11 May 2021 11:43:35 GMT, Tejpal Rebari wrote: >> Hi All, >> Please review the following fix for jdk17. >> >> Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full >> Screen when the System Preference -> General -> Prefer Tab

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v4]

ndowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. > > Test : Added a manual test and tested on MacOS 10.15 and 11. > All the internal tests run are gre

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v4]

On Mon, 17 May 2021 05:57:18 GMT, Tejpal Rebari wrote: >> Hi All, >> Please review the following fix for jdk17. >> >> Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full >> Screen when the System Preference -> General -> Prefer Tab

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v5]

ndowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. > > Test : Added a manual test and tested on MacOS 10.15 and 11. > All the internal tests run are green. Tejp

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v3]

On Thu, 13 May 2021 20:43:01 GMT, Phil Race wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> code cleanup > > src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWind

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v5]

On Thu, 20 May 2021 08:09:09 GMT, Tejpal Rebari wrote: >> Hi All, >> Please review the following fix for jdk17. >> >> Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full >> Screen when the System Preference -> General -> Prefer Tab

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v6]

ndowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. > > Test : Added a manual test and tested on MacOS 10.15 and 11. > All the internal tests run are gre

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v6]

On Fri, 28 May 2021 12:26:31 GMT, Tejpal Rebari wrote: >> Hi All, >> Please review the following fix for jdk17. >> >> Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full >> Screen when the System Preference -> General -> Prefer Tab

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v7]

ndowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. > > Test : Added a manual test and tested on MacOS 10.15 and 11. > All the internal tests run are green. Tejpal

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v5]

On Thu, 20 May 2021 19:50:32 GMT, Sergey Bylokhov wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 1107: >> >>> 1105: JNI_COCOA_ENTER(env); >>> 1106: if (allowAutomaticTabbing) { >>> 1107: [NSWindow setAllowsAutomaticWindowTabbing:YES]; >> >> Should we

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v7]

On Mon, 31 May 2021 11:23:46 GMT, Jayathirth D V wrote: >> Tejpal Rebari has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - make string final >> - doPrivileged to the system.getproperty > > src/j

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v8]

ndowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. > > Test : Added a manual test and tested on MacOS 10.15 and 11. > All the internal tests run are green. Tejpal

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v9]

ndowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. > > Test : Added a manual test and tested on MacOS 10.15 and 11. > All the internal tests run are green. Tejp

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v8]

On Thu, 3 Jun 2021 11:48:41 GMT, Kevin Rushforth wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated the comment > > test/jdk/java/awt/Window/TestAppFreeze.java line 64: >

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v10]

ndowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. > > Test : Added a manual test and tested on MacOS 10.15 and 11. > All the internal tests run are green. Tej

Re: RFR: 8256465: [macos] Java frame and dialog presented full screen freeze application [v11]

ndowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. > > Test : Added a manual test and tested on MacOS 10.15 and 11. > All the internal tests run are green. Tejpal

Re: RFR: 8256465: [macos] Java frame and dialog presented full screen freeze application [v10]

On Fri, 4 Jun 2021 13:48:18 GMT, Kevin Rushforth wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add SupressWarnings and test changes > > test/jdk/java/awt/Window/TestAppFreeze.jav

Integrated: 8256465: [macos] Java frame and dialog presented full screen freeze application

On Fri, 9 Apr 2021 05:42:37 GMT, Tejpal Rebari wrote: > Hi All, > Please review the following fix for jdk17. > > Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full > Screen when the System Preference -> General -> Prefer Tabs is set to "F

Re: RFR: 8268620: InfiniteLoopException test may fail on x86 platforms

On Mon, 14 Jun 2021 17:18:15 GMT, Sergey Bylokhov wrote: > Small test update. > > This test posts lots of events to EDT from the different threads, and it > checks that the robot.waitForIdle() on the main thread will not hang or throw > an exception. And this test fails on x86. The post of eve