Hi Erik
Looks good to me as well.
Tim
Looks good to me.
/Magnus
On 27 mar 2014, at 12:47, Erik Joelsson wrote:
Further testing revealed some more issues. New webrev:
http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/
I had to break out the devkit/sysroot parts from from BASIC_SETU
On 12/29/14 04:22, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 9.
libjawt was removed from the libawt_xawt. See bug report for
additional information.
Bug: https://bugs.openjdk.java.net/browse/JDK-8056214
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8056214/webrev.
Magnus:
Looks good to me as well.
Tim
On 03/04/15 05:31, Erik Joelsson wrote:
Hello,
Really nice to finally see this patch getting done!
Only one comment:
flags.m4:
In the grep expression, could you move the extra [] outside of the
actual command line options to grep so that the command li
Phil:
On 08/16/2017 11:09 AM, Phil Race wrote:
http://cr.openjdk.java.net/~prr/8186259/
I'll take any reviewer on this which just fixes the JTREG test so that
jtreg does not blow up.
Looks good. Approved.
Tim
Hello everyone
Unfortunately there is no public link for 8012925
This is a one-line change in jdk/src/macosx/native/sun/awt/AWTEvent.m to
return a value (0) instead of returning nothing. Returning 0 is
consistent with the code at line 418 in the same method:
http://cr.openjdk.java.net/~t
