[9] Review Request: 8143054 [macosx] KeyEvent modifiers do not contain information about mouse buttons

2015-11-18 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. On macosx when we create a KeyEvent we ignore the mouse state of all mouse buttons, which means that mouse modifiers are missing. The only KeyEvent is affected, because when we convert NS modifiers to java modifiers we use nsToJavaKeyModifiers(), but in

Re: Review-request for 8143227: Platform-Specific Desktop Features

2015-11-18 Thread Sergey Bylokhov
FYI. I start to check the osx part. On 18.11.15 17:01, Alexander Zvegintsev wrote: Hi Alexander, resending the same webrev under the new ID https://bugs.openjdk.java.net/browse/JDK-8143227 http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/ The approach is pretty the same as it was in

Re: [OpenJDK 2D-Dev] [rfc]Stream doesn't reset mark in finally

2015-11-18 Thread Jiri Vanek
On 11/12/2015 02:24 PM, Sergey Bylokhov wrote: Hi, Jiri. This is a valid point, did you file a new CR for this issue? Hello! here it is: https://jvanek.fedorapeople.org/oracle/jdk8/webrevs/resetInTryFinally/v1/ Patch:

Re: Java 8 updates are causing "Apps that use non-public APIs will be rejected"

2015-11-18 Thread Kevin Rushforth
[moving this back to the openjfx alias; Bcc awt-dev] The javapackager fix for JDK 8u72 does exactly this when generating .pkg files. So in short, libjfxwebkit.dylib is unchanged for 8u72, but will be excluded when generating an app for the Apple app store. -- Kevin Michael Hall wrote: On